[parser] Clean up (pre)parser traits, part 5, last

[parser] Clean up (pre)parser traits, part 5, last

This patch moves the following methods from the traits objects to
the (pre)parser implementation objects:

- AddFormalParameter
- AddParameterInitializationBlock
- DeclareFormalParameter
- ExpressionListToExpression
- GetNonPatternList
- GetReportedErrorList
- IsTaggedTemplate
- MaterializeUnspreadArgumentsLiterals
- NoTemplateTag
- ParseArrowFunctionFormalParameterList
- ReindexLiterals
- SetFunctionNameFromIdentifierRef
- SetFunctionNameFromPropertyName

It moves the Void method from the preparser traits object to the
preparser implementation object.  It also removes the traits zone
method and replaces it with that of ParserBase, which it turns to
public.

After all this, the traits objects contain just typedefs and the
delegate methods are no more necessary.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/ba9367db6097083f7f3d8ef6982e7f7b65cdaaf7
Cr-Commit-Position: refs/heads/master@{#38892}

[nickie, 2016-08-24 17:23:20]

The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 17:23:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 17:44:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:44:56]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-08-24 18:19:40]

lgtm

Exciting!

https://codereview.chromium.org/2277843002/diff/1/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2277843002/diff/1/src/parsing/parser.h#newcod...
src/parsing/parser.h:984: V8_INLINE void DeclareFormalParameter(
Hmm, surprised that this and the above were already inline (they probably should
be). Fine for this patch since you're not changing it, but I think we need to be
thoughtful about this going forward.

[marja, 2016-08-25 07:33:56]

lgtm

https://codereview.chromium.org/2277843002/diff/1/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2277843002/diff/1/src/parsing/parser.h#newcod...
src/parsing/parser.h:200: friend class
v8::internal::ExpressionClassifier<ParserBaseTraits<Parser>>;
Pls add a "TODO: remove this, pass the needed data as ctor params to
ExpressionClassifier" or sth along those lines.

[nickie, 2016-08-25 08:47:02]

The CQ bit was checked by nikolaos@chromium.org

[commit-bot: I haz the power, 2016-08-25 08:47:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 08:48:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-25 08:49:01]

Description was changed from

==========
[parser] Clean up (pre)parser traits, part 5, last

This patch moves the following methods from the traits objects to
the (pre)parser implementation objects:

- AddFormalParameter
- AddParameterInitializationBlock
- DeclareFormalParameter
- ExpressionListToExpression
- GetNonPatternList
- GetReportedErrorList
- IsTaggedTemplate
- MaterializeUnspreadArgumentsLiterals
- NoTemplateTag
- ParseArrowFunctionFormalParameterList
- ReindexLiterals
- SetFunctionNameFromIdentifierRef
- SetFunctionNameFromPropertyName

It moves the Void method from the preparser traits object to the
preparser implementation object.  It also removes the traits zone
method and replaces it with that of ParserBase, which it turns to
public.

After all this, the traits objects contain just typedefs and the
delegate methods are no more necessary.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N
==========

to

==========
[parser] Clean up (pre)parser traits, part 5, last

This patch moves the following methods from the traits objects to
the (pre)parser implementation objects:

- AddFormalParameter
- AddParameterInitializationBlock
- DeclareFormalParameter
- ExpressionListToExpression
- GetNonPatternList
- GetReportedErrorList
- IsTaggedTemplate
- MaterializeUnspreadArgumentsLiterals
- NoTemplateTag
- ParseArrowFunctionFormalParameterList
- ReindexLiterals
- SetFunctionNameFromIdentifierRef
- SetFunctionNameFromPropertyName

It moves the Void method from the preparser traits object to the
preparser implementation object.  It also removes the traits zone
method and replaces it with that of ParserBase, which it turns to
public.

After all this, the traits objects contain just typedefs and the
delegate methods are no more necessary.

R=adamk@chromium.org, marja@chromium.org
BUG=
LOG=N

Committed: https://crrev.com/ba9367db6097083f7f3d8ef6982e7f7b65cdaaf7
Cr-Commit-Position: refs/heads/master@{#38892}
==========

[commit-bot: I haz the power, 2016-08-25 08:49:02]

Patchset 1 (id:??) landed as
https://crrev.com/ba9367db6097083f7f3d8ef6982e7f7b65cdaaf7
Cr-Commit-Position: refs/heads/master@{#38892}