setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on non-macOS platforms.

setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on non-macOS platforms.

setSelectionRange(s, e) unexpectedly called the four-argument version of HTMLTextFormControlElement::setSelectionRange() with SelectionHasNoDirection.
So it set "none" direction without EditingBehavior check.

This CL renames the implementation function of web-exposed setSelectionRange() to
setSelectionRangeForBinding(), and makes its third argument optional so that
seSelectionRange(s, e) calls it.

On non-macOS platforms, two tests in textfieldselection-setSelectionRange.html
correctly fail.

BUG=640861
Committed: https://crrev.com/9cde715f00643052484f4cb60ed0d9593b5661ca
Cr-Commit-Position: refs/heads/master@{#414306}

[tkent, 2016-08-24 09:54:51]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 09:55:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 11:42:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 11:42:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2016-08-25 00:17:02]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 00:18:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-25 00:22:21]

Description was changed from

==========
Cleanup of HTMLTextFormControlElement::setSelectionRange(four-arguments)

BUG=
==========

to

==========
setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on
non-macOS platforms.

setSelectionRange(s, e) unexpectedly called HTMLTextFormControlElement::
setSelectionRange(int, int, TextFieldSelectionDirection,
NeedToDispatchSelectEvent).
So it set "none" direction without EditingBehavior check.

This CL renames the implementation function of web-exposed setSelectionRange()
to
setSelectionRangeForBinding(), and makes its third argument optional.

On non-macOS platforms, two tests in textfieldselection-setSelectionRange.html
correctly fail.
==========

[tkent, 2016-08-25 00:22:31]

Patchset #1 (id:1) has been deleted

[tkent, 2016-08-25 02:03:03]

Description was changed from

==========
setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on
non-macOS platforms.

setSelectionRange(s, e) unexpectedly called HTMLTextFormControlElement::
setSelectionRange(int, int, TextFieldSelectionDirection,
NeedToDispatchSelectEvent).
So it set "none" direction without EditingBehavior check.

This CL renames the implementation function of web-exposed setSelectionRange()
to
setSelectionRangeForBinding(), and makes its third argument optional.

On non-macOS platforms, two tests in textfieldselection-setSelectionRange.html
correctly fail.
==========

to

==========
setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on
non-macOS platforms.

setSelectionRange(s, e) unexpectedly called the four-argument version of
HTMLTextFormControlElement::setSelectionRange() with SelectionHasNoDirection.
So it set "none" direction without EditingBehavior check.

This CL renames the implementation function of web-exposed setSelectionRange()
to
setSelectionRangeForBinding(), and makes its third argument optional so that
seSelectionRange(s, e) calls it.

On non-macOS platforms, two tests in textfieldselection-setSelectionRange.html
correctly fail.
==========

[tkent, 2016-08-25 02:26:06]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-08-25 02:26:06]

yosin@, would you review this please?

[commit-bot: I haz the power, 2016-08-25 02:43:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 02:43:33]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-08-25 03:52:37]

Description was changed from

==========
setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on
non-macOS platforms.

setSelectionRange(s, e) unexpectedly called the four-argument version of
HTMLTextFormControlElement::setSelectionRange() with SelectionHasNoDirection.
So it set "none" direction without EditingBehavior check.

This CL renames the implementation function of web-exposed setSelectionRange()
to
setSelectionRangeForBinding(), and makes its third argument optional so that
seSelectionRange(s, e) calls it.

On non-macOS platforms, two tests in textfieldselection-setSelectionRange.html
correctly fail.
==========

to

==========
setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on
non-macOS platforms.

setSelectionRange(s, e) unexpectedly called the four-argument version of
HTMLTextFormControlElement::setSelectionRange() with SelectionHasNoDirection.
So it set "none" direction without EditingBehavior check.

This CL renames the implementation function of web-exposed setSelectionRange()
to
setSelectionRangeForBinding(), and makes its third argument optional so that
seSelectionRange(s, e) calls it.

On non-macOS platforms, two tests in textfieldselection-setSelectionRange.html
correctly fail.

BUG=640861
==========

[yosin_UTC9, 2016-08-25 04:10:13]

lgtm

BTW, when INPUT/TEXTAREA has focus on non-macOS, FrameSelection::setSelection()
always sets directional.

[tkent, 2016-08-25 04:11:36]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-08-25 04:12:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 04:16:08]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-08-25 04:18:28]

Description was changed from

==========
setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on
non-macOS platforms.

setSelectionRange(s, e) unexpectedly called the four-argument version of
HTMLTextFormControlElement::setSelectionRange() with SelectionHasNoDirection.
So it set "none" direction without EditingBehavior check.

This CL renames the implementation function of web-exposed setSelectionRange()
to
setSelectionRangeForBinding(), and makes its third argument optional so that
seSelectionRange(s, e) calls it.

On non-macOS platforms, two tests in textfieldselection-setSelectionRange.html
correctly fail.

BUG=640861
==========

to

==========
setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on
non-macOS platforms.

setSelectionRange(s, e) unexpectedly called the four-argument version of
HTMLTextFormControlElement::setSelectionRange() with SelectionHasNoDirection.
So it set "none" direction without EditingBehavior check.

This CL renames the implementation function of web-exposed setSelectionRange()
to
setSelectionRangeForBinding(), and makes its third argument optional so that
seSelectionRange(s, e) calls it.

On non-macOS platforms, two tests in textfieldselection-setSelectionRange.html
correctly fail.

BUG=640861

Committed: https://crrev.com/9cde715f00643052484f4cb60ed0d9593b5661ca
Cr-Commit-Position: refs/heads/master@{#414306}
==========

[commit-bot: I haz the power, 2016-08-25 04:18:29]

Patchset 1 (id:??) landed as
https://crrev.com/9cde715f00643052484f4cb60ed0d9593b5661ca
Cr-Commit-Position: refs/heads/master@{#414306}