Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2274103002: setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on non-macOS platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
index 659200e894ed79772802d449b2f314dbd9b66a11..7e77c07556be4a4f9c77343e8c8f2d71818d8586 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
@@ -587,7 +587,7 @@ void HTMLInputElement::setSelectionRangeForBinding(int start, int end, Exception
exceptionState.throwDOMException(InvalidStateError, "The input element's type ('" + m_inputType->formControlType() + "') does not support selection.");
return;
}
- HTMLTextFormControlElement::setSelectionRange(start, end);
+ HTMLTextFormControlElement::setSelectionRangeForBinding(start, end);
}
void HTMLInputElement::setSelectionRangeForBinding(int start, int end, const String& direction, ExceptionState& exceptionState)
@@ -596,7 +596,7 @@ void HTMLInputElement::setSelectionRangeForBinding(int start, int end, const Str
exceptionState.throwDOMException(InvalidStateError, "The input element's type ('" + m_inputType->formControlType() + "') does not support selection.");
return;
}
- HTMLTextFormControlElement::setSelectionRange(start, end, direction);
+ HTMLTextFormControlElement::setSelectionRangeForBinding(start, end, direction);
}
void HTMLInputElement::accessKeyAction(bool sendMouseEvents)

Powered by Google App Engine
This is Rietveld 408576698