third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h - Issue 2274103002: setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on non-macOS platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

Issue 2274103002: setSelectionRange() for INPUT and TEXTAREA should not set "none" direction on non-macOS platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextAreaElement.idl ('k') | third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

index 55e3f2008a0723e4f33e0f242ebab0732b41bba0..b4e03dfba403de8dae408db3ade09efab1ee7c6e 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h

@@ -70,7 +70,11 @@ public:

void select(NeedToDispatchSelectEvent = DispatchSelectEvent);

virtual void setRangeText(const String& replacement, ExceptionState&);

virtual void setRangeText(const String& replacement, unsigned start, unsigned end, const String& selectionMode, ExceptionState&);

- void setSelectionRange(int start, int end, const String& direction);

+ // Web-exposed setSelectionRange() function. This translates "none"

+ // direction to "forward" if necessary.

+ void setSelectionRangeForBinding(int start, int end, const String& direction = "none");

+ // Blink-internal version of setSelectionRange(). This never translates

+ // "none" direction.

void setSelectionRange(int start, int end, TextFieldSelectionDirection = SelectionHasNoDirection, NeedToDispatchSelectEvent = DispatchSelectEvent);

Range* selection() const;