Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2273993002: Converted Observatory cpu-profile-table element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Converted Observatory cpu-profile-table element Fixes=https://github.com/dart-lang/sdk/issues/27116 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/44d2b85d3d20b87fe3168ce42ee3f470e5ed205c

Patch Set 1 #

Patch Set 2 : Updated observatory_sources.gypi #

Patch Set 3 : Added tests #

Total comments: 2

Patch Set 4 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+628 lines, -1137 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 3 6 chunks +22 lines, -19 lines 0 comments Download
M runtime/observatory/lib/src/cpu_profile/cpu_profile.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/containers/virtual_collection.dart View 3 chunks +21 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile/virtual_tree.dart View 2 chunks +11 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile_table.dart View 1 chunk +401 lines, -879 lines 0 comments Download
D runtime/observatory/lib/src/elements/cpu_profile_table.html View 1 chunk +0 lines, -218 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 3 1 chunk +133 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_ref.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/function.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/sample_profile.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
A + runtime/observatory/tests/observatory_ui/cpu_profile_table/element_test.dart View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/cpu_profile_table/element_test.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/sample_profile.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
cbernaschina
4 years, 3 months ago (2016-08-24 00:44:59 UTC) #3
cbernaschina
4 years, 3 months ago (2016-08-24 02:29:13 UTC) #5
Cutch
lgtm https://codereview.chromium.org/2273993002/diff/40001/runtime/observatory/lib/src/app/page.dart File runtime/observatory/lib/src/app/page.dart (right): https://codereview.chromium.org/2273993002/diff/40001/runtime/observatory/lib/src/app/page.dart#newcode290 runtime/observatory/lib/src/app/page.dart:290: DivElement container = new DivElement(); this could be ...
4 years, 3 months ago (2016-08-24 13:53:41 UTC) #6
cbernaschina
https://codereview.chromium.org/2273993002/diff/40001/runtime/observatory/lib/src/app/page.dart File runtime/observatory/lib/src/app/page.dart (right): https://codereview.chromium.org/2273993002/diff/40001/runtime/observatory/lib/src/app/page.dart#newcode290 runtime/observatory/lib/src/app/page.dart:290: DivElement container = new DivElement(); On 2016/08/24 13:53:41, Cutch ...
4 years, 3 months ago (2016-08-24 15:34:43 UTC) #7
cbernaschina
Committed patchset #4 (id:60001) manually as 44d2b85d3d20b87fe3168ce42ee3f470e5ed205c (presubmit successful).
4 years, 3 months ago (2016-08-24 15:51:48 UTC) #10
cbernaschina
4 years, 3 months ago (2016-08-24 15:56:08 UTC) #11
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698