runtime/observatory/lib/src/cpu_profile/cpu_profile.dart - Issue 2273993002: Converted Observatory cpu-profile-table element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/cpu_profile/cpu_profile.dart

Issue 2273993002: Converted Observatory cpu-profile-table element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/cpu_profile/cpu_profile.dart

diff --git a/runtime/observatory/lib/src/cpu_profile/cpu_profile.dart b/runtime/observatory/lib/src/cpu_profile/cpu_profile.dart

index f96f5dbd3d776dee256073821b50fdb3fd14ef34..9cb7ebd7745b58b4356432fc1332e886c82e2e2b 100644

--- a/runtime/observatory/lib/src/cpu_profile/cpu_profile.dart

+++ b/runtime/observatory/lib/src/cpu_profile/cpu_profile.dart

@@ -104,7 +104,7 @@ class FunctionCallTreeNode extends CallTreeNode {

int _totalCodeTicks = 0;

int get totalCodesTicks => _totalCodeTicks;

- String get name => profileFunction.function.name;

+ String get name => M.getFunctionFullName(profileFunction.function);

Object get profileData => profileFunction;

FunctionCallTreeNode(this.profileFunction, int count)