Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: runtime/observatory/lib/src/elements/function_ref.dart

Issue 2273993002: Converted Observatory cpu-profile-table element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/function_ref.dart
diff --git a/runtime/observatory/lib/src/elements/function_ref.dart b/runtime/observatory/lib/src/elements/function_ref.dart
index 204169db8b8afc99e04019b89767dac081463737..2f18c91b37193344cfe15026f23c4074df49970c 100644
--- a/runtime/observatory/lib/src/elements/function_ref.dart
+++ b/runtime/observatory/lib/src/elements/function_ref.dart
@@ -7,7 +7,8 @@ library function_ref_element;
import 'dart:html';
import 'dart:async';
import 'package:observatory/models.dart' as M
- show IsolateRef, FunctionRef, isSyntheticFunction, ClassRef, ObjectRef;
+ show IsolateRef, FunctionRef, isSyntheticFunction, ClassRef, ObjectRef,
+ getFunctionFullName;
import 'package:observatory/src/elements/class_ref.dart';
import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
import 'package:observatory/src/elements/helpers/tag.dart';
@@ -53,12 +54,13 @@ class FunctionRefElement extends HtmlElement implements Renderable {
void detached() {
super.detached();
children = [];
+ title = '';
_r.disable(notify: true);
}
void render() {
var content = <Element>[
- new AnchorElement(href: M.isSyntheticFunction(function.kind) ? null
+ new AnchorElement(href: M.isSyntheticFunction(_function.kind) ? null
: Uris.inspect(_isolate, object: _function))
..text = _function.name
];
@@ -82,5 +84,6 @@ class FunctionRefElement extends HtmlElement implements Renderable {
}
}
children = content.reversed.toList(growable: false);
+ title = M.getFunctionFullName(_function);
}
}
« no previous file with comments | « runtime/observatory/lib/src/elements/css/shared.css ('k') | runtime/observatory/lib/src/models/objects/function.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698