cc : Delete LayerImpl::OnOpacityAnimated

cc : Delete LayerImpl::OnOpacityAnimated

Use EffectTree::OnOpacityAnimated instead

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/b5bc1a25619808772d15bdcb5bb3819fda8c24cd
Cr-Commit-Position: refs/heads/master@{#413960}

[jaydasika, 2016-08-23 23:00:37]

Description was changed from

==========
cc : Delete LayerImpl::OnOpacityAnimated

Use EffectTree::OnOpacityAnimated instead

BUG=638297
==========

to

==========
cc : Delete LayerImpl::OnOpacityAnimated

Use EffectTree::OnOpacityAnimated instead

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[jaydasika, 2016-08-23 23:12:00]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-08-23 23:12:01]

PTAL

https://codereview.chromium.org/2273933002/diff/1/cc/input/scrollbar_animatio...
File cc/input/scrollbar_animation_controller_linear_fade.cc (right):

https://codereview.chromium.org/2273933002/diff/1/cc/input/scrollbar_animatio...
cc/input/scrollbar_animation_controller_linear_fade.cc:67: }
OnOpacityAnimated can be called during layer's PushPropertiesTo for scrollbars
(PushProperties -> RegisterScrollbar-> updateScrollbar ->
ApplyopacityToScrollbar -> OnOpacityAnimated), but during activation we
implicitly overwrite this value because we push property trees after we push
layer properties. So, here, I first check if the scrollbar's id is in effect
tree's id_to_index_map. If it isn't => the call is happening during
PushPropertiesTo and we don't have to update opacity.

[ajuma, 2016-08-23 23:48:16]

lgtm

https://codereview.chromium.org/2273933002/diff/1/cc/input/scrollbar_animatio...
File cc/input/scrollbar_animation_controller_linear_fade.cc (right):

https://codereview.chromium.org/2273933002/diff/1/cc/input/scrollbar_animatio...
cc/input/scrollbar_animation_controller_linear_fade.cc:67: }
On 2016/08/23 23:12:01, jaydasika wrote:
> OnOpacityAnimated can be called during layer's PushPropertiesTo for scrollbars
> (PushProperties -> RegisterScrollbar-> updateScrollbar ->
> ApplyopacityToScrollbar -> OnOpacityAnimated), but during activation we
> implicitly overwrite this value because we push property trees after we push
> layer properties. So, here, I first check if the scrollbar's id is in effect
> tree's id_to_index_map. If it isn't => the call is happening during
> PushPropertiesTo and we don't have to update opacity.

Please add a comment about this.

https://codereview.chromium.org/2273933002/diff/1/cc/input/scrollbar_animatio...
File cc/input/scrollbar_animation_controller_thinning.cc (right):

https://codereview.chromium.org/2273933002/diff/1/cc/input/scrollbar_animatio...
cc/input/scrollbar_animation_controller_thinning.cc:148: if
(property_trees->IsInIdToIndexMap(PropertyTrees::TreeType::EFFECT,
Here too, please add a comment.

[jaydasika, 2016-08-24 00:37:46]

https://codereview.chromium.org/2273933002/diff/1/cc/input/scrollbar_animatio...
File cc/input/scrollbar_animation_controller_linear_fade.cc (right):

https://codereview.chromium.org/2273933002/diff/1/cc/input/scrollbar_animatio...
cc/input/scrollbar_animation_controller_linear_fade.cc:67: }
On 2016/08/23 23:48:16, ajuma wrote:
> On 2016/08/23 23:12:01, jaydasika wrote:
> > OnOpacityAnimated can be called during layer's PushPropertiesTo for
scrollbars
> > (PushProperties -> RegisterScrollbar-> updateScrollbar ->
> > ApplyopacityToScrollbar -> OnOpacityAnimated), but during activation we
> > implicitly overwrite this value because we push property trees after we push
> > layer properties. So, here, I first check if the scrollbar's id is in effect
> > tree's id_to_index_map. If it isn't => the call is happening during
> > PushPropertiesTo and we don't have to update opacity.
> 
> Please add a comment about this.

Done.

https://codereview.chromium.org/2273933002/diff/1/cc/input/scrollbar_animatio...
File cc/input/scrollbar_animation_controller_thinning.cc (right):

https://codereview.chromium.org/2273933002/diff/1/cc/input/scrollbar_animatio...
cc/input/scrollbar_animation_controller_thinning.cc:148: if
(property_trees->IsInIdToIndexMap(PropertyTrees::TreeType::EFFECT,
On 2016/08/23 23:48:16, ajuma wrote:
> Here too, please add a comment.

Done.

[jaydasika, 2016-08-24 00:37:49]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-08-24 00:37:50]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2273933002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-08-24 00:38:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 02:59:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-24 03:00:54]

Description was changed from

==========
cc : Delete LayerImpl::OnOpacityAnimated

Use EffectTree::OnOpacityAnimated instead

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc : Delete LayerImpl::OnOpacityAnimated

Use EffectTree::OnOpacityAnimated instead

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/b5bc1a25619808772d15bdcb5bb3819fda8c24cd
Cr-Commit-Position: refs/heads/master@{#413960}
==========

[commit-bot: I haz the power, 2016-08-24 03:00:55]

Patchset 2 (id:??) landed as
https://crrev.com/b5bc1a25619808772d15bdcb5bb3819fda8c24cd
Cr-Commit-Position: refs/heads/master@{#413960}