cc : Delete LayerImpl::OnOpacityAnimated

cc/input/scrollbar_animation_controller_thinning.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/input/scrollbar_animation_controller_thinning.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/time/time.h"
 #include "cc/layers/layer_impl.h"
 #include "cc/layers/scrollbar_layer_impl_base.h"
@@ skipping 125 matching lines @@
     float opacity,
     float thumb_thickness_scale) {
   for (ScrollbarLayerImplBase* scrollbar : Scrollbars()) {
     if (!scrollbar->is_overlay_scrollbar())
       continue;
     float effective_opacity =
         scrollbar->CanScrollOrientation()
             ? AdjustScale(opacity, scrollbar->Opacity(), opacity_change_)
             : 0;
 
-    scrollbar->OnOpacityAnimated(effective_opacity);
+    PropertyTrees* property_trees =
+        scrollbar->layer_tree_impl()->property_trees();
+    // If this method is called during LayerImpl::PushPropertiesTo, we may not
+    // yet have valid effect_id_to_index_map entries as property trees are
+    // pushed after layers during activation. We can skip updating opacity in
+    // that case as we are only registering a scrollbar and because opacity will
+    // be overwritten anyway when property trees are pushed.
+    if (property_trees->IsInIdToIndexMap(PropertyTrees::TreeType::EFFECT,
+                                         scrollbar->id())) {
+      property_trees->effect_tree.OnOpacityAnimated(
+          effective_opacity,
+          property_trees->effect_id_to_index_map[scrollbar->id()],
+          scrollbar->layer_tree_impl());
+    }
     scrollbar->SetThumbThicknessScaleFactor(AdjustScale(
         thumb_thickness_scale, scrollbar->thumb_thickness_scale_factor(),
         thickness_change_));
   }
 }
 
 }  // namespace cc