Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2272953002: [Findit] Moving check flake parameters to config (Closed)

Created:
4 years, 4 months ago by lijeffrey
Modified:
4 years, 3 months ago
Reviewers:
chanli, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Moving check flake parameters to config BUG=639542 Committed: https://chromium.googlesource.com/infra/infra/+/b1474528edcca30a7b4bfc7d16e725157bc764cd

Patch Set 1 #

Patch Set 2 : Fixing naming in html file #

Total comments: 2

Patch Set 3 : Addressing comments #

Patch Set 4 : Updating swarming settings config example #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -108 lines) Patch
M appengine/findit/handlers/config.py View 1 2 4 chunks +15 lines, -1 line 0 comments Download
M appengine/findit/handlers/test/config_test.py View 1 2 18 chunks +119 lines, -10 lines 0 comments Download
M appengine/findit/model/wf_config.py View 1 2 3 2 chunks +14 lines, -1 line 0 comments Download
M appengine/findit/templates/config.html View 1 4 chunks +7 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/flake/recursive_flake_pipeline.py View 6 chunks +71 lines, -65 lines 0 comments Download
M appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/test/waterfall_config_test.py View 1 2 2 chunks +14 lines, -1 line 0 comments Download
M appengine/findit/waterfall/test/wf_testcase.py View 1 2 3 chunks +13 lines, -1 line 0 comments Download
M appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py View 1 2 7 chunks +19 lines, -17 lines 0 comments Download
M appengine/findit/waterfall/trigger_flake_swarming_task_pipeline.py View 1 2 2 chunks +13 lines, -10 lines 0 comments Download
M appengine/findit/waterfall/waterfall_config.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
lijeffrey
ptal
4 years, 4 months ago (2016-08-24 05:43:16 UTC) #2
stgao
Mind also move https://chromium.googlesource.com/infra/infra/+/master/appengine/findit/waterfall/trigger_flake_swarming_task_pipeline.py#32 to config? https://codereview.chromium.org/2272953002/diff/20001/appengine/findit/model/wf_config.py File appengine/findit/model/wf_config.py (right): https://codereview.chromium.org/2272953002/diff/20001/appengine/findit/model/wf_config.py#newcode91 appengine/findit/model/wf_config.py:91: # introduces test ...
4 years, 4 months ago (2016-08-24 16:13:43 UTC) #3
chanli
On 2016/08/24 16:13:43, stgao wrote: > Mind also move > https://chromium.googlesource.com/infra/infra/+/master/appengine/findit/waterfall/trigger_flake_swarming_task_pipeline.py#32 > to config? > ...
4 years, 3 months ago (2016-08-26 00:57:47 UTC) #4
lijeffrey
comments addressed, ptal https://codereview.chromium.org/2272953002/diff/20001/appengine/findit/model/wf_config.py File appengine/findit/model/wf_config.py (right): https://codereview.chromium.org/2272953002/diff/20001/appengine/findit/model/wf_config.py#newcode91 appengine/findit/model/wf_config.py:91: # introduces test flakiness. On 2016/08/24 ...
4 years, 3 months ago (2016-08-26 01:40:45 UTC) #5
stgao
lgtm
4 years, 3 months ago (2016-08-26 04:04:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272953002/60001
4 years, 3 months ago (2016-08-26 04:04:50 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/infra/infra/+/b1474528edcca30a7b4bfc7d16e725157bc764cd
4 years, 3 months ago (2016-08-26 04:18:36 UTC) #11
lijeffrey
On 2016/08/26 04:18:36, commit-bot: I haz the power wrote: > Committed patchset #4 (id:60001) as ...
4 years, 3 months ago (2016-08-26 08:01:16 UTC) #12
lijeffrey
4 years, 3 months ago (2016-08-26 08:02:12 UTC) #13
Message was sent while issue was closed. 
On 2016/08/26 08:01:16, lijeffrey wrote:
> On 2016/08/26 04:18:36, commit-bot: I haz the power wrote:
> > Committed patchset #4 (id:60001) as
> >
>
https://chromium.googlesource.com/infra/infra/+/b1474528edcca30a7b4bfc7d16e72...
> 
> Thanks guys, I've updated Findit's config to include the new swarming settings
> and check flake settings as follows:
> 
> swarming:
> {
>   ...
>   "get_swarming_task_id_timeout_seconds": 300,
>   "get_swarming_task_id_wait_seconds": 10,
> }
> 
> check flake:
> {
>   "iterations_to_rerun": 100,
>   "lower_flake_threshold": 0.01,
>   "max_flake_in_a_row": 4,
>   "max_stable_in_a_row": 4,
>   "upper_flake_threshold": 0.98
> }
> 
> This way when the next version of Findit is deployed the settings should
already
> be there.

Sorry that's 0.02 for lower_flake_threshold.

Powered by Google App Engine
This is Rietveld 408576698