Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2718)

Unified Diff: appengine/findit/waterfall/test/wf_testcase.py

Issue 2272953002: [Findit] Moving check flake parameters to config (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Updating swarming settings config example Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/wf_testcase.py
diff --git a/appengine/findit/waterfall/test/wf_testcase.py b/appengine/findit/waterfall/test/wf_testcase.py
index 1af17b16b37567d4cea54c9ac692eb8acd484827..7f984a59a609b8af10eead465e64691ab0c36ece 100644
--- a/appengine/findit/waterfall/test/wf_testcase.py
+++ b/appengine/findit/waterfall/test/wf_testcase.py
@@ -88,7 +88,9 @@ _DEFAULT_SWARMING_SETTINGS = {
'task_timeout_hours': 23,
'isolated_server': 'https://isolateserver.appspot.com',
'isolated_storage_url': 'isolateserver.storage.googleapis.com',
- 'iterations_to_rerun': 10
+ 'iterations_to_rerun': 10,
+ 'get_swarming_task_id_timeout_seconds': 5 * 60, # 5 minutes.
+ 'get_swarming_task_id_wait_seconds': 10,
}
@@ -105,6 +107,15 @@ _DEFAULT_ACTION_SETTINGS = {
}
+_DEFAULT_CHECK_FLAKE_SETTINGS = {
+ 'lower_flake_threshold': 0.02,
+ 'upper_flake_threshold': 0.98,
+ 'max_flake_in_a_row': 4,
+ 'max_stable_in_a_row': 4,
+ 'iterations_to_rerun': 100
+}
+
+
DEFAULT_CONFIG_DATA = {
'steps_for_masters_rules': _DEFAULT_STEPS_FOR_MASTERS_RULES,
'builders_to_trybots': _DEFAULT_TRY_BOT_MAPPING,
@@ -112,6 +123,7 @@ DEFAULT_CONFIG_DATA = {
'swarming_settings': _DEFAULT_SWARMING_SETTINGS,
'download_build_data_settings': _DEFAULT_DOWNLOAD_BUILD_DATA_SETTINGS,
'action_settings': _DEFAULT_ACTION_SETTINGS,
+ 'check_flake_settings': _DEFAULT_CHECK_FLAKE_SETTINGS
}

Powered by Google App Engine
This is Rietveld 408576698