Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2162)

Unified Diff: appengine/findit/waterfall/test/waterfall_config_test.py

Issue 2272953002: [Findit] Moving check flake parameters to config (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Updating swarming settings config example Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/test/waterfall_config_test.py
diff --git a/appengine/findit/waterfall/test/waterfall_config_test.py b/appengine/findit/waterfall/test/waterfall_config_test.py
index ce5a11820b2fa5d49d906e544e08e978e9acecec..871e5420d560eeb622cedac01c248f1c95bd9c36 100644
--- a/appengine/findit/waterfall/test/waterfall_config_test.py
+++ b/appengine/findit/waterfall/test/waterfall_config_test.py
@@ -98,7 +98,9 @@ class MastersTest(wf_testcase.WaterfallTestCase):
'task_timeout_hours': 23,
'isolated_server': 'https://isolateserver.appspot.com',
'isolated_storage_url': 'isolateserver.storage.googleapis.com',
- 'iterations_to_rerun': 10
+ 'iterations_to_rerun': 10,
+ 'get_swarming_task_id_timeout_seconds': 300,
+ 'get_swarming_task_id_wait_seconds': 10
},
waterfall_config.GetSwarmingSettings())
@@ -133,3 +135,14 @@ class MastersTest(wf_testcase.WaterfallTestCase):
'cr_notification_latency_limit_minutes': 30,
},
waterfall_config.GetActionSettings())
+
+ def testGetCheckFlakeSettings(self):
+ self.assertEqual(
+ {
+ 'lower_flake_threshold': 0.02,
+ 'upper_flake_threshold': 0.98,
+ 'max_flake_in_a_row': 4,
+ 'max_stable_in_a_row': 4,
+ 'iterations_to_rerun': 100
+ },
+ waterfall_config.GetCheckFlakeSettings())

Powered by Google App Engine
This is Rietveld 408576698