[Remoting Android] New touch feedback texture

[Remoting Android] New touch feedback texture

Currently the touch feedback animation texture is a intricate radial gradient
which doesn't look very good under the new OpenGL renderer. This CL changes to
use a simpler texture design that is consisted of a dark circle inside a white
ring, which would further match the ink ripple spec of material design.

BUG=638425
Committed: https://crrev.com/d63f07075f833e6dcce793b87a529569f3fe4827
Cr-Commit-Position: refs/heads/master@{#414141}

[Yuwei, 2016-08-23 20:42:55]

Description was changed from

==========
[Chromoting Android] New touch feedback texture

Currently the touch feedback animation texture is a intricate radial gradient
which doesn't look very good under the new OpenGL renderer. This CL changes to
use a simpler texture design that is consisted of a dark circle inside a white
ring, which would further match the ink ripple spec of material design.

BUG=638425
==========

to

==========
[Remoting Android] New touch feedback texture

Currently the touch feedback animation texture is a intricate radial gradient
which doesn't look very good under the new OpenGL renderer. This CL changes to
use a simpler texture design that is consisted of a dark circle inside a white
ring, which would further match the ink ripple spec of material design.

BUG=638425
==========

[Yuwei, 2016-08-24 01:00:55]

yuweih@chromium.org changed reviewers:
+ joedow@chromium.org

[Yuwei, 2016-08-24 01:00:55]

New design got LGTM from Jon :)

PTAL

[joedow, 2016-08-24 01:50:02]

Does this also affect Trackpad input for longpressing?

Without having seen it, I'd like to make sure it looks good when using 'mouse'
input and isn't too much like a touch animation.

[Yuwei, 2016-08-24 17:59:22]

On 2016/08/24 01:50:02, joedow wrote:
> Does this also affect Trackpad input for longpressing?

Yes.

> Without having seen it, I'd like to make sure it looks good when using 'mouse'
> input and isn't too much like a touch animation.

It does kind of look like a touch animation. The old texture doesn't look any
better though. Maybe I can reduce the size for longpress animation.

[Yuwei, 2016-08-24 18:44:24]

Added TINY_SCALED_ANIMATION and made feedback being drawn below the cursor.

PTAL

[joedow, 2016-08-24 18:53:28]

https://codereview.chromium.org/2272793003/diff/20001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/DesktopView.java (right):

https://codereview.chromium.org/2272793003/diff/20001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopView.java:24: public
enum InputFeedbackType { NONE, SMALL_ANIMATION, LARGE_ANIMATION,
TINY_SCALED_ANIMATION }
Now that we've broken the touch and trackpad feedback types, I think it would be
more clear to change this enum to "SHORT_TOUCH_ANIMATION, LONG_TOUCH_ANIMATION,
LONG_TRACKPAD_ANIMATION" or similar.

https://codereview.chromium.org/2272793003/diff/20001/remoting/client/gl_rend...
File remoting/client/gl_renderer.cc (right):

https://codereview.chromium.org/2272793003/diff/20001/remoting/client/gl_rend...
remoting/client/gl_renderer.cc:139: cursor_.Draw();
I think it would be good to add some comments (either a block or inline) about
the layers.  At the moment we only have desktop, feedback, and cursor, but
perhaps we will want to add another layer in the future or someone reading the
code might wonder why/whether this order matters.

[Yuwei, 2016-08-24 19:06:44]

ptal

https://codereview.chromium.org/2272793003/diff/20001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/DesktopView.java (right):

https://codereview.chromium.org/2272793003/diff/20001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopView.java:24: public
enum InputFeedbackType { NONE, SMALL_ANIMATION, LARGE_ANIMATION,
TINY_SCALED_ANIMATION }
On 2016/08/24 18:53:28, joedow wrote:
> Now that we've broken the touch and trackpad feedback types, I think it would
be
> more clear to change this enum to "SHORT_TOUCH_ANIMATION,
LONG_TOUCH_ANIMATION,
> LONG_TRACKPAD_ANIMATION" or similar.

Done.

https://codereview.chromium.org/2272793003/diff/20001/remoting/client/gl_rend...
File remoting/client/gl_renderer.cc (right):

https://codereview.chromium.org/2272793003/diff/20001/remoting/client/gl_rend...
remoting/client/gl_renderer.cc:139: cursor_.Draw();
On 2016/08/24 18:53:28, joedow wrote:
> I think it would be good to add some comments (either a block or inline) about
> the layers.  At the moment we only have desktop, feedback, and cursor, but
> perhaps we will want to add another layer in the future or someone reading the
> code might wonder why/whether this order matters.

Done.

[joedow, 2016-08-24 19:11:06]

lgtm after nits are addressed

https://codereview.chromium.org/2272793003/diff/40001/remoting/android/java/r...
File remoting/android/java/res/values/dimens.xml (right):

https://codereview.chromium.org/2272793003/diff/40001/remoting/android/java/r...
remoting/android/java/res/values/dimens.xml:10: <dimen
name="long_touch_animation_radius">55dp</dimen>
I think using tiny/small/large here is totally fine since these are removed from
the implementation, sorry I wasn't clear about that.

https://codereview.chromium.org/2272793003/diff/40001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/DesktopView.java (right):

https://codereview.chromium.org/2272793003/diff/40001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopView.java:145: return
mLongTrackpadAnimationRadius;
A comment here on why this value isn't being normalized by the scalefactor would
be good.

[Yuwei, 2016-08-24 20:05:43]

https://codereview.chromium.org/2272793003/diff/40001/remoting/android/java/r...
File remoting/android/java/res/values/dimens.xml (right):

https://codereview.chromium.org/2272793003/diff/40001/remoting/android/java/r...
remoting/android/java/res/values/dimens.xml:10: <dimen
name="long_touch_animation_radius">55dp</dimen>
On 2016/08/24 19:11:06, joedow wrote:
> I think using tiny/small/large here is totally fine since these are removed
from
> the implementation, sorry I wasn't clear about that.

Done.

https://codereview.chromium.org/2272793003/diff/40001/remoting/android/java/s...
File remoting/android/java/src/org/chromium/chromoting/DesktopView.java (right):

https://codereview.chromium.org/2272793003/diff/40001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/DesktopView.java:145: return
mLongTrackpadAnimationRadius;
On 2016/08/24 19:11:06, joedow wrote:
> A comment here on why this value isn't being normalized by the scalefactor
would
> be good.

Done.

[Yuwei, 2016-08-24 20:05:57]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2016-08-24 20:05:58]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2272793003/#ps60001
(title: "Reviewer's Feedback")

[commit-bot: I haz the power, 2016-08-24 20:06:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 20:55:54]

Description was changed from

==========
[Remoting Android] New touch feedback texture

Currently the touch feedback animation texture is a intricate radial gradient
which doesn't look very good under the new OpenGL renderer. This CL changes to
use a simpler texture design that is consisted of a dark circle inside a white
ring, which would further match the ink ripple spec of material design.

BUG=638425
==========

to

==========
[Remoting Android] New touch feedback texture

Currently the touch feedback animation texture is a intricate radial gradient
which doesn't look very good under the new OpenGL renderer. This CL changes to
use a simpler texture design that is consisted of a dark circle inside a white
ring, which would further match the ink ripple spec of material design.

BUG=638425
==========

[commit-bot: I haz the power, 2016-08-24 20:55:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-24 20:58:00]

Description was changed from

==========
[Remoting Android] New touch feedback texture

Currently the touch feedback animation texture is a intricate radial gradient
which doesn't look very good under the new OpenGL renderer. This CL changes to
use a simpler texture design that is consisted of a dark circle inside a white
ring, which would further match the ink ripple spec of material design.

BUG=638425
==========

to

==========
[Remoting Android] New touch feedback texture

Currently the touch feedback animation texture is a intricate radial gradient
which doesn't look very good under the new OpenGL renderer. This CL changes to
use a simpler texture design that is consisted of a dark circle inside a white
ring, which would further match the ink ripple spec of material design.

BUG=638425

Committed: https://crrev.com/d63f07075f833e6dcce793b87a529569f3fe4827
Cr-Commit-Position: refs/heads/master@{#414141}
==========

[commit-bot: I haz the power, 2016-08-24 20:58:02]

Patchset 4 (id:??) landed as
https://crrev.com/d63f07075f833e6dcce793b87a529569f3fe4827
Cr-Commit-Position: refs/heads/master@{#414141}