remoting/android/java/res/values/dimens.xml - Issue 2272793003: [Remoting Android] New touch feedback texture

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/android/java/res/values/dimens.xml

Issue 2272793003: [Remoting Android] New touch feedback texture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reviewer's Feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources>	6 <resources>

7 <dimen name="toolbar_content_inset_start">72dp</dimen>	7 <dimen name="toolbar_content_inset_start">72dp</dimen>

8 <dimen name="feedback_animation_radius_small">25dp</dimen>	8 <dimen name="long_trackpad_animation_radius">8dp</dimen>

9 <dimen name="feedback_animation_radius_large">55dp</dimen>	9 <dimen name="short_touch_animation_radius">25dp</dimen>

	10 <dimen name="long_touch_animation_radius">55dp</dimen>
	joedow 2016/08/24 19:11:06 I think using tiny/small/large here is totally fin I think using tiny/small/large here is totally fine since these are removed from the implementation, sorry I wasn't clear about that. Yuwei 2016/08/24 20:05:43 Done. Show quoted text On 2016/08/24 19:11:06, joedow wrote: > I think using tiny/small/large here is totally fine since these are removed from > the implementation, sorry I wasn't clear about that. Done.
10 </resources>	11 </resources>

OLD	NEW