remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java - Issue 2272793003: [Remoting Android] New touch feedback texture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

Issue 2272793003: [Remoting Android] New touch feedback texture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reviewer's Feedback Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/DesktopView.java ('k') | remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

diff --git a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

index 00fbdf310c86afac9af8f359ce026eb4a00120ee..dff7c5bc3c825e873bf586ac02b2bdc480ac1896 100644

--- a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

+++ b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

@@ -39,12 +39,12 @@ public class GlDesktopView extends DesktopView implements SurfaceHolder.Callback

@Override

public void showInputFeedback(InputFeedbackType feedbackToShow, PointF pos) {

- float diameter = getFeedbackRadius(feedbackToShow) * 2.0f;

+ float scaleFactor = mRenderData.transform.mapRadius(1);

+ float diameter = getFeedbackRadius(feedbackToShow, scaleFactor) * 2.0f;

if (diameter <= 0.0f) {

return;

}

- float scaleFactor = mRenderData.transform.mapRadius(1);

- mDisplay.showCursorInputFeedback(pos.x, pos.y, diameter / scaleFactor);

+ mDisplay.showCursorInputFeedback(pos.x, pos.y, diameter);

}

@Override