third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

index eb67fcb18bca58e5006653264f28a4a2a322ad84..1ebbac1680fb91be681f1f480f3c831ecf5a8bf7 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp

@@ -283,8 +283,6 @@ static void constructCustomElement(const v8::FunctionCallbackInfo<v8::Value>& in

ExceptionState exceptionState(ExceptionState::ConstructionContext, "CustomElement", info.Holder(), info.GetIsolate());

V0CustomElementProcessingStack::CallbackDeliveryScope deliveryScope;

Element* element = document->createElementNS(namespaceURI, tagName, maybeType->IsNull() ? nullAtom : type, exceptionState);

- if (exceptionState.throwIfNeeded())

- return;

v8SetReturnValueFast(info, element, document);

}