third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp

index 94880015422af35d638f4b873ee46dbbb0e2ccf3..221dbe331ec57b92d388f4545915338177ca0262 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp

@@ -116,7 +116,6 @@ void V8WrapperInstantiationScope::securityCheck(v8::Isolate* isolate, v8::Local<

return;

CHECK_EQ(SecurityError, exceptionState.code());

- exceptionState.throwIfNeeded();

return;

}

const DOMWrapperWorld& currentWorld = DOMWrapperWorld::world(m_context);

@@ -125,7 +124,6 @@ void V8WrapperInstantiationScope::securityCheck(v8::Isolate* isolate, v8::Local<

ExceptionState exceptionState(ExceptionState::ConstructionContext, nullptr, contextForWrapper->Global(), isolate);

if (currentWorld.isMainWorld() && !BindingSecurity::shouldAllowAccessToFrame(currentDOMWindow(isolate), frame, exceptionState)) {

CHECK_EQ(SecurityError, exceptionState.code());

- exceptionState.throwIfNeeded();

return;

}

@@ -138,7 +136,6 @@ void V8WrapperInstantiationScope::convertException()

LocalDOMWindow* callingWindow = currentDOMWindow(isolate);

DOMWindow* targetWindow = toDOMWindow(m_context);

exceptionState.throwSecurityError(targetWindow->sanitizedCrossDomainAccessErrorMessage(callingWindow), targetWindow->crossDomainAccessErrorMessage(callingWindow));

- exceptionState.throwIfNeeded();

}

} // namespace blink