third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp - Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

Issue 2272613003: binding: Retires ExceptionState::throwIfNeeded(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp » ('j') | third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

index 4da926a81f14e7d7417aa6ee02a9a62ab05102de..00fc8be54aa69f937329dc6a6a5ec124671b15e8 100644

--- a/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

@@ -267,7 +267,6 @@ void rethrowExceptionInPrivateScript(v8::Isolate* isolate, v8::TryCatch& block,

ScriptState::Scope scope(scriptStateInUserScript);

ExceptionState exceptionState(errorContext, propertyName, interfaceName, context->Global(), scriptStateInUserScript->isolate());

exceptionState.throwDOMException(exceptionCode, messageString);

- exceptionState.throwIfNeeded();

return;

}

@@ -279,7 +278,6 @@ void rethrowExceptionInPrivateScript(v8::Isolate* isolate, v8::TryCatch& block,

ScriptState::Scope scope(scriptStateInUserScript);

ExceptionState exceptionState(errorContext, propertyName, interfaceName, scriptStateInUserScript->context()->Global(), scriptStateInUserScript->isolate());

exceptionState.throwDOMException(V8RangeError, messageString);

- exceptionState.throwIfNeeded();

return;

}