Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2276063002: [api] Disable new and delete using = delete. (Closed)

Created:
4 years, 4 months ago by Franzi
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@ApiDeleteStyle
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Disable new and delete using = delete. According to our style guide on Copyable and Movable Types, copy/move operators should be disabled using = delete in the public: section. Use consistent style for disabling new and delete. BUG= Committed: https://crrev.com/8ce60a195c2e6514e892d70f791b002980361dcf Cr-Commit-Position: refs/heads/master@{#38880}

Patch Set 1 #

Patch Set 2 : Fix depends on problem. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -25 lines) Patch
M include/v8.h View 6 chunks +12 lines, -25 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (11 generated)
Franzi
4 years, 4 months ago (2016-08-24 17:53:39 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-24 20:47:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276063002/20001
4 years, 4 months ago (2016-08-25 04:25:09 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-25 04:27:29 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 04:27:52 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ce60a195c2e6514e892d70f791b002980361dcf
Cr-Commit-Position: refs/heads/master@{#38880}

Powered by Google App Engine
This is Rietveld 408576698