arc: Fix appearing duplicate icons in recent.

arc: Fix appearing duplicate icons in recent.

Filter out Arc apps that should not come to Arc app list
search result.

TEST=Manually
BUG=640253
BUG=b/30977618

Committed: https://crrev.com/4b6f8dc28e19c486554dba2bc8855781cd724ca5
Cr-Commit-Position: refs/heads/master@{#413819}

[khmel, 2016-08-23 17:34:35]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2016-08-23 17:34:36]

Hi Xiyuan,

PTAL

[xiyuan, 2016-08-23 17:57:42]

lgtm

https://codereview.chromium.org/2270733003/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/search/app_search_provider.cc (right):

https://codereview.chromium.org/2270733003/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/search/app_search_provider.cc:207: if
(!app_info->launchable || !app_info->showInLauncher)
Just double check, would this cover the Settings app ?

[khmel, 2016-08-23 17:58:07]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2016-08-23 17:58:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-08-23 18:12:47]

https://codereview.chromium.org/2270733003/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/search/app_search_provider.cc (right):

https://codereview.chromium.org/2270733003/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/search/app_search_provider.cc:207: if
(!app_info->launchable || !app_info->showInLauncher)
On 2016/08/23 17:57:41, xiyuan wrote:
> Just double check, would this cover the Settings app ?

Got a chance to check this?

[khmel, 2016-08-23 18:13:57]

On 2016/08/23 18:12:47, xiyuan wrote:
>
https://codereview.chromium.org/2270733003/diff/1/chrome/browser/ui/app_list/...
> File chrome/browser/ui/app_list/search/app_search_provider.cc (right):
> 
>
https://codereview.chromium.org/2270733003/diff/1/chrome/browser/ui/app_list/...
> chrome/browser/ui/app_list/search/app_search_provider.cc:207: if
> (!app_info->launchable || !app_info->showInLauncher)
> On 2016/08/23 17:57:41, xiyuan wrote:
> > Just double check, would this cover the Settings app ?
> 
> Got a chance to check this?

Yes, I tested Settings and App Info as well.

[khmel, 2016-08-23 18:15:10]

https://codereview.chromium.org/2270733003/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/search/app_search_provider.cc (right):

https://codereview.chromium.org/2270733003/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/search/app_search_provider.cc:207: if
(!app_info->launchable || !app_info->showInLauncher)
On 2016/08/23 18:12:47, xiyuan wrote:
> On 2016/08/23 17:57:41, xiyuan wrote:
> > Just double check, would this cover the Settings app ?
> 
> Got a chance to check this?

Sorry, forgot to answer.
Yes, checked Settings & Arc App Info app. They do not appear in recent and
search.

[xiyuan, 2016-08-23 18:19:43]

On 2016/08/23 18:15:10, khmel wrote:
>
https://codereview.chromium.org/2270733003/diff/1/chrome/browser/ui/app_list/...
> File chrome/browser/ui/app_list/search/app_search_provider.cc (right):
> 
>
https://codereview.chromium.org/2270733003/diff/1/chrome/browser/ui/app_list/...
> chrome/browser/ui/app_list/search/app_search_provider.cc:207: if
> (!app_info->launchable || !app_info->showInLauncher)
> On 2016/08/23 18:12:47, xiyuan wrote:
> > On 2016/08/23 17:57:41, xiyuan wrote:
> > > Just double check, would this cover the Settings app ?
> > 
> > Got a chance to check this?
> 
> Sorry, forgot to answer.
> Yes, checked Settings & Arc App Info app. They do not appear in recent and
> search.

Cool. Thanks for confirming.

[commit-bot: I haz the power, 2016-08-23 19:56:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-23 19:57:43]

Description was changed from

==========
arc: Fix appearing duplicate icons in recent.

Filter out Arc apps that should not come to Arc app list
search result.

TEST=Manually
BUG=640253
BUG=b/30977618
==========

to

==========
arc: Fix appearing duplicate icons in recent.

Filter out Arc apps that should not come to Arc app list
search result.

TEST=Manually
BUG=640253
BUG=b/30977618

Committed: https://crrev.com/4b6f8dc28e19c486554dba2bc8855781cd724ca5
Cr-Commit-Position: refs/heads/master@{#413819}
==========

[commit-bot: I haz the power, 2016-08-23 19:57:44]

Patchset 1 (id:??) landed as
https://crrev.com/4b6f8dc28e19c486554dba2bc8855781cd724ca5
Cr-Commit-Position: refs/heads/master@{#413819}