arc: Fix appearing duplicate icons in recent.

chrome/browser/ui/app_list/search/app_search_provider.cc

Index: chrome/browser/ui/app_list/search/app_search_provider.cc
diff --git a/chrome/browser/ui/app_list/search/app_search_provider.cc b/chrome/browser/ui/app_list/search/app_search_provider.cc
index b69678150136cc7ba53191c0378b117b39879641..cf9a73c7cba50862a3d5a936bc12cc8c18ed9d4f 100644
--- a/chrome/browser/ui/app_list/search/app_search_provider.cc
+++ b/chrome/browser/ui/app_list/search/app_search_provider.cc
@@ -197,9 +197,6 @@ class ArcDataSource : public AppSearchProvider::DataSource,
 
     const std::vector<std::string> app_ids = arc_prefs->GetAppIds();
     for (const auto& app_id : app_ids) {
-      if (!arc::ShouldShowInLauncher(app_id))
-        continue;
-
       std::unique_ptr<ArcAppListPrefs::AppInfo> app_info =
           arc_prefs->GetApp(app_id);
       if (!app_info) {
@@ -207,6 +204,9 @@ class ArcDataSource : public AppSearchProvider::DataSource,
         continue;
       }
 
+      if (!app_info->launchable || !app_info->showInLauncher)

[xiyuan, 2016/08/23 17:57:41]

Just double check, would this cover the Settings app ?

[xiyuan, 2016/08/23 18:12:47]

Got a chance to check this?

[khmel, 2016/08/23 18:15:10]

Sorry, forgot to answer.
Yes, checked Settings & Arc App Info app. They do not appear in recent and
search.

+        continue;
+
       std::unique_ptr<AppSearchProvider::App> app(new AppSearchProvider::App(
           this, app_id, app_info->name, app_info->last_launch_time,
           app_info->install_time));
@@ -286,7 +286,6 @@ void AppSearchProvider::Start(bool /*is_voice_query*/,
 void AppSearchProvider::Stop() {
 }
 
-
 void AppSearchProvider::RefreshApps() {
   apps_.clear();
   for (auto& data_source : data_sources_) {