arc: Fix appearing duplicate icons in recent.

chrome/browser/ui/app_list/search/app_search_provider.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/search/app_search_provider.h"
 
 #include <stddef.h>
 #include <string>
 #include <utility>
 
@@ skipping 179 matching lines @@
     ArcAppListPrefs::Get(profile())->RemoveObserver(this);
   }
 
   // AppSearchProvider::DataSource overrides:
   void AddApps(AppSearchProvider::Apps* apps) override {
     ArcAppListPrefs* arc_prefs = ArcAppListPrefs::Get(profile());
     CHECK(arc_prefs);
 
     const std::vector<std::string> app_ids = arc_prefs->GetAppIds();
     for (const auto& app_id : app_ids) {
-      if (!arc::ShouldShowInLauncher(app_id))
-        continue;
-
       std::unique_ptr<ArcAppListPrefs::AppInfo> app_info =
           arc_prefs->GetApp(app_id);
       if (!app_info) {
         NOTREACHED();
         continue;
       }
 
+      if (!app_info->launchable || !app_info->showInLauncher)

[xiyuan, 2016/08/23 17:57:41]

Just double check, would this cover the Settings app ?

[xiyuan, 2016/08/23 18:12:47]

Got a chance to check this?

[khmel, 2016/08/23 18:15:10]

Sorry, forgot to answer.
Yes, checked Settings & Arc App Info app. They do not appear in recent and
search.

+        continue;
+
       std::unique_ptr<AppSearchProvider::App> app(new AppSearchProvider::App(
           this, app_id, app_info->name, app_info->last_launch_time,
           app_info->install_time));
       apps->push_back(std::move(app));
     }
   }
 
   std::unique_ptr<AppResult> CreateResult(
       const std::string& app_id,
       AppListControllerDelegate* list_controller,
@@ skipping 59 matching lines @@
   // This will also cause the results to update.
   if (show_recommendations)
     RefreshApps();
 
   UpdateResults();
 }
 
 void AppSearchProvider::Stop() {
 }
 
-
 void AppSearchProvider::RefreshApps() {
   apps_.clear();
   for (auto& data_source : data_sources_) {
     data_source->AddApps(&apps_);
   }
 }
 
 void AppSearchProvider::UpdateResults() {
   const TokenizedString query_terms(query_);
   bool show_recommendations = query_.empty();
@@ skipping 57 matching lines @@
   } else {
     if (!update_results_factory_.HasWeakPtrs()) {
       base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE, base::Bind(&AppSearchProvider::UpdateResults,
                                 update_results_factory_.GetWeakPtr()));
     }
   }
 }
 
 }  // namespace app_list