Issue 227073002: Treats the returned value from ui::TextInputClient as DIP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227073002: Treats the returned value from ui::TextInputClient as DIP (Closed)

Created:
6 years, 8 months ago by yukawa

Modified:
6 years, 8 months ago

Reviewers:
Seigo Nonaka, Yuki

CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Treats the returned value from ui::TextInputClient as DIP On Windows, the returned value from ui::TextInputClient as DIP is supposed to be DIP (Density Independent Pixel). This CL adds relevant coordinate conversion so that IME UI can be placed at the proper position when HiDPI is enabled on Windows. This CL does not cover Win8 (Ash) mode. BUG=260529, 360334 TEST=Manually tested on Windows 8.1 w/ and w/o HiDPI is enabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262473

Patch Set 1 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -6 lines)			Patch
	M	ui/base/ime/input_method_win.cc	View		4 chunks	+12 lines, -4 lines	0 comments	Download
	M	ui/base/ime/text_input_client.h	View		2 chunks	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yukawa

On 2014/04/05 13:05:22, yukawa wrote: > Hey Nonaka-san, could you take a look? Friendly ping?

6 years, 8 months ago (2014-04-08 07:55:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/227073002/20001

6 years, 8 months ago (2014-04-08 15:43:57 UTC) #5

Message was sent while issue was closed.

Change committed as 262473

Expand Messages | Collapse Messages