Treats the returned value from ui::TextInputClient as DIP

ui/base/ime/input_method_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/ime/input_method_win.h"
 
 #include "base/basictypes.h"
 #include "ui/base/ime/text_input_client.h"
 #include "ui/base/ime/win/tsf_input_scope.h"
 #include "ui/events/event.h"
 #include "ui/events/event_constants.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/keycodes/keyboard_codes.h"
+#include "ui/gfx/win/dpi.h"
 #include "ui/gfx/win/hwnd_util.h"
 
 namespace ui {
 namespace {
 
 // Extra number of chars before and after selection (or composition) range which
 // is returned to IME for improving conversion accuracy.
 static const size_t kExtraNumberOfChars = 20;
 
 }  // namespace
@@ skipping 124 matching lines @@
   UpdateIMEState();
 }
 
 void InputMethodWin::OnCaretBoundsChanged(const TextInputClient* client) {
   if (!enabled_ || !IsTextInputClientFocused(client) ||
       !IsWindowFocused(client)) {
     return;
   }
   // The current text input type should not be NONE if |client| is focused.
   DCHECK(!IsTextInputTypeNone());
-  gfx::Rect screen_bounds(GetTextInputClient()->GetCaretBounds());
+  // Tentatively assume that the returned value is DIP (Density Independent
+  // Pixel). See the comment in text_input_client.h and http://crbug.com/360334.
+  const gfx::Rect dip_screen_bounds(GetTextInputClient()->GetCaretBounds());
+  const gfx::Rect screen_bounds = gfx::win::DIPToScreenRect(dip_screen_bounds);
 
   HWND attached_window = GetAttachedWindowHandle(client);
   // TODO(ime): see comment in TextInputClient::GetCaretBounds(), this
   // conversion shouldn't be necessary.
   RECT r = {};
   GetClientRect(attached_window, &r);
   POINT window_point = { screen_bounds.x(), screen_bounds.y() };
   ScreenToClient(attached_window, &window_point);
   gfx::Rect caret_rect(gfx::Point(window_point.x, window_point.y),
                        screen_bounds.size());
@@ skipping 342 matching lines @@
   if (!char_positon)
     return 0;
 
   if (char_positon->dwSize < sizeof(IMECHARPOSITION))
     return 0;
 
   ui::TextInputClient* client = GetTextInputClient();
   if (!client)
     return 0;
 
-  gfx::Rect rect;
+  // Tentatively assume that the returned value from |client| is DIP (Density
+  // Independent Pixel). See the comment in text_input_client.h and
+  // http://crbug.com/360334.
+  gfx::Rect dip_rect;
   if (client->HasCompositionText()) {
     if (!client->GetCompositionCharacterBounds(char_positon->dwCharPos,
-                                               &rect)) {
+                                               &dip_rect)) {
       return 0;
     }
   } else {
     // If there is no composition and the first character is queried, returns
     // the caret bounds. This behavior is the same to that of RichEdit control.
     if (char_positon->dwCharPos != 0)
       return 0;
-    rect = client->GetCaretBounds();
+    dip_rect = client->GetCaretBounds();
   }
+  const gfx::Rect rect = gfx::win::DIPToScreenRect(dip_rect);
 
   char_positon->pt.x = rect.x();
   char_positon->pt.y = rect.y();
   char_positon->cLineHeight = rect.height();
   return 1;  // returns non-zero value when succeeded.
 }
 
 HWND InputMethodWin::GetAttachedWindowHandle(
   const TextInputClient* text_input_client) const {
   // On Aura environment, we can assume that |toplevel_window_handle_| always
@@ skipping 56 matching lines @@
       enabled_ = true;
       break;
   }
 
   imm32_manager_.SetTextInputMode(window_handle, text_input_mode);
   tsf_inputscope::SetInputScopeForTsfUnawareWindow(
       window_handle, text_input_type, text_input_mode);
 }
 
 }  // namespace ui