Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: ui/base/ime/text_input_client.h

Issue 227073002: Treats the returned value from ui::TextInputClient as DIP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/ime/input_method_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/text_input_client.h
diff --git a/ui/base/ime/text_input_client.h b/ui/base/ime/text_input_client.h
index 23671641b9b3501778ad2fa99dd57cb0567bc99f..6581519d02f22721c45dd0df864802b99354f0a1 100644
--- a/ui/base/ime/text_input_client.h
+++ b/ui/base/ime/text_input_client.h
@@ -71,16 +71,24 @@ class UI_BASE_EXPORT TextInputClient {
// Returns if the client supports inline composition currently.
virtual bool CanComposeInline() const = 0;
- // Returns current caret (insertion point) bounds relative to the screen
+ // Returns current caret (insertion point) bounds in the universal screen
// coordinates. If there is selection, then the selection bounds will be
// returned.
+ // Note: On Windows, the returned value is supposed to be DIP (Density
+ // Independent Pixel).
+ // TODO(ime): Have a clear spec whether the returned value is DIP or not.
+ // http://crbug.com/360334
virtual gfx::Rect GetCaretBounds() const = 0;
- // Retrieves the composition character boundary rectangle relative to the
+ // Retrieves the composition character boundary rectangle in the universal
// screen coordinates. The |index| is zero-based index of character position
// in composition text.
// Returns false if there is no composition text or |index| is out of range.
// The |rect| is not touched in the case of failure.
+ // Note: On Windows, the returned value is supposed to be DIP
+ // (Density Independent Pixel).
+ // TODO(ime): Have a clear spec whether the returned value is DIP or not.
+ // http://crbug.com/360334
virtual bool GetCompositionCharacterBounds(uint32 index,
gfx::Rect* rect) const = 0;
@@ -146,6 +154,10 @@ class UI_BASE_EXPORT TextInputClient {
// Ensure the caret is within |rect|. |rect| is in screen coordinates and
// may extend beyond the bounds of this TextInputClient.
+ // Note: On Windows, the returned value is supposed to be DIP (Density
+ // Independent Pixel).
+ // TODO(ime): Have a clear spec whether the returned value is DIP or not.
+ // http://crbug.com/360334
virtual void EnsureCaretInRect(const gfx::Rect& rect) = 0;
// Called when IME shows a candidate window.
« no previous file with comments | « ui/base/ime/input_method_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698