Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2251073002: CSS: SVG use elements replicate updates to style (Closed)

Created:
4 years, 4 months ago by Eric Willigers
Modified:
4 years, 4 months ago
Reviewers:
dstockwell, fs, rune
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS: SVG use elements replicate updates to style When an SVG element's style is being updated, shadow instances created by <use> elements must also be updated. We weren't previously propagating the change until the the next time the <use> element's style happened to be recalculated. For example, this bug has been reported with style updates due to a pseudo-class change, a class change or a CSS animation. BUG=166438, 355359, 484552, 637310 Committed: https://crrev.com/98eafa054ec08b60ab06632b39c543982c20dfdc Cr-Commit-Position: refs/heads/master@{#413048}

Patch Set 1 : layout tests #

Total comments: 5

Patch Set 2 : instance not <use> subtree #

Total comments: 8

Patch Set 3 : tidy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -0 lines) Patch
A + third_party/WebKit/LayoutTests/animations/css-animation-affects-use-elements.html View 2 chunks +4 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/css-animation-affects-use-elements-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/animations/css-composite-animation-affects-use-elements.html View 2 chunks +8 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/animations/css-composite-animation-affects-use-elements-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-class.html View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-class-expected.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-inline.html View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-inline-expected.html View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo.html View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
Eric Willigers
4 years, 4 months ago (2016-08-18 06:51:13 UTC) #6
fs
+rune
4 years, 4 months ago (2016-08-18 09:09:11 UTC) #10
rune
https://codereview.chromium.org/2251073002/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp File third_party/WebKit/Source/core/dom/Node.cpp (right): https://codereview.chromium.org/2251073002/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp#newcode718 third_party/WebKit/Source/core/dom/Node.cpp:718: element->setNeedsStyleRecalc(SubtreeStyleChange, reason); So there's an 1:n relationship between each ...
4 years, 4 months ago (2016-08-18 21:09:07 UTC) #11
rune
https://codereview.chromium.org/2251073002/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp File third_party/WebKit/Source/core/dom/Node.cpp (right): https://codereview.chromium.org/2251073002/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp#newcode712 third_party/WebKit/Source/core/dom/Node.cpp:712: return; I think I'd move the code below into ...
4 years, 4 months ago (2016-08-18 21:15:29 UTC) #12
fs
https://codereview.chromium.org/2251073002/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp File third_party/WebKit/Source/core/dom/Node.cpp (right): https://codereview.chromium.org/2251073002/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp#newcode718 third_party/WebKit/Source/core/dom/Node.cpp:718: element->setNeedsStyleRecalc(SubtreeStyleChange, reason); On 2016/08/18 at 21:09:07, rune wrote: > ...
4 years, 4 months ago (2016-08-18 21:21:17 UTC) #13
Eric Willigers
https://codereview.chromium.org/2251073002/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp File third_party/WebKit/Source/core/dom/Node.cpp (right): https://codereview.chromium.org/2251073002/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp#newcode712 third_party/WebKit/Source/core/dom/Node.cpp:712: return; On 2016/08/18 21:15:28, rune wrote: > I think ...
4 years, 4 months ago (2016-08-18 22:27:00 UTC) #15
rune
lgtm with nits. https://codereview.chromium.org/2251073002/diff/40001/third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html File third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html (right): https://codereview.chromium.org/2251073002/diff/40001/third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html#newcode4 third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html:4: <meta charset="utf-8"> Drop html/head/body/meta. https://codereview.chromium.org/2251073002/diff/40001/third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo.html File ...
4 years, 4 months ago (2016-08-18 23:43:07 UTC) #16
rune
lgtm with nits. https://codereview.chromium.org/2251073002/diff/40001/third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html File third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html (right): https://codereview.chromium.org/2251073002/diff/40001/third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html#newcode4 third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html:4: <meta charset="utf-8"> Drop html/head/body/meta. https://codereview.chromium.org/2251073002/diff/40001/third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo.html File ...
4 years, 4 months ago (2016-08-18 23:43:07 UTC) #17
Eric Willigers
https://codereview.chromium.org/2251073002/diff/40001/third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html File third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html (right): https://codereview.chromium.org/2251073002/diff/40001/third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html#newcode4 third_party/WebKit/LayoutTests/svg/css/use-replicates-changes-pseudo-expected.html:4: <meta charset="utf-8"> On 2016/08/18 23:43:06, rune wrote: > Drop ...
4 years, 4 months ago (2016-08-19 00:44:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251073002/60001
4 years, 4 months ago (2016-08-19 00:45:26 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 4 months ago (2016-08-19 04:26:11 UTC) #23
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 04:28:19 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/98eafa054ec08b60ab06632b39c543982c20dfdc
Cr-Commit-Position: refs/heads/master@{#413048}

Powered by Google App Engine
This is Rietveld 408576698