Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2270253002: Give precedence to trusty-updates in trusty sysroot (Closed)

Created:
4 years, 4 months ago by Tom (Use chromium acct)
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@RefactorSysrootCreator
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give precedence to trusty-updates in trusty sysroot Pull package lists from both trusty and trusty-updates, and give precedence to the packages in trusty-updates when deciding which packages to add to the sysroot. BUG=638394 Committed: https://crrev.com/22d47117c3c32d50f233ba6c92dc8c76c275634f Cr-Commit-Position: refs/heads/master@{#414233}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Refactor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -25 lines) Patch
A build/linux/sysroot_scripts/merge-package-lists.py View 1 1 chunk +35 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator.sh View 1 5 chunks +34 lines, -22 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-jessie.sh View 1 chunk +0 lines, -1 line 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-trusty.sh View 1 chunk +1 line, -1 line 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
Tom (Use chromium acct)
4 years, 4 months ago (2016-08-23 23:30:36 UTC) #3
Tom (Use chromium acct)
+dpranke
4 years, 4 months ago (2016-08-24 17:13:20 UTC) #8
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-24 18:31:35 UTC) #9
Lei Zhang
lgtm https://codereview.chromium.org/2270253002/diff/1/build/linux/sysroot_scripts/merge-package-lists.py File build/linux/sysroot_scripts/merge-package-lists.py (right): https://codereview.chromium.org/2270253002/diff/1/build/linux/sysroot_scripts/merge-package-lists.py#newcode2 build/linux/sysroot_scripts/merge-package-lists.py:2: # Copyright (c) 2016 The Chromium Authors. All ...
4 years, 4 months ago (2016-08-24 18:37:02 UTC) #10
Tom (Use chromium acct)
https://codereview.chromium.org/2270253002/diff/1/build/linux/sysroot_scripts/merge-package-lists.py File build/linux/sysroot_scripts/merge-package-lists.py (right): https://codereview.chromium.org/2270253002/diff/1/build/linux/sysroot_scripts/merge-package-lists.py#newcode2 build/linux/sysroot_scripts/merge-package-lists.py:2: # Copyright (c) 2016 The Chromium Authors. All rights ...
4 years, 4 months ago (2016-08-24 22:45:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270253002/20001
4 years, 4 months ago (2016-08-24 22:45:44 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 00:55:06 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 00:58:58 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/22d47117c3c32d50f233ba6c92dc8c76c275634f
Cr-Commit-Position: refs/heads/master@{#414233}

Powered by Google App Engine
This is Rietveld 408576698