Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2273813003: Linux: Refactor sysroot-creator (Closed)

Created:
4 years, 4 months ago by Tom (Use chromium acct)
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor sysroot-creator Clean up some duplicate code in sysroot-creator.sh to make it easier to implement pulling in packages from precise-updates for the (future) precise sysroot. BUG=638394 Committed: https://crrev.com/d95e6aa7ad7027c7acbe706099f56734562eaa01 Cr-Commit-Position: refs/heads/master@{#413980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -53 lines) Patch
M build/linux/sysroot_scripts/sysroot-creator.sh View 5 chunks +27 lines, -51 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-trusty.sh View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
Tom (Use chromium acct)
4 years, 4 months ago (2016-08-23 20:06:09 UTC) #4
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-24 04:45:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273813003/1
4 years, 4 months ago (2016-08-24 04:46:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 04:49:36 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 04:51:15 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d95e6aa7ad7027c7acbe706099f56734562eaa01
Cr-Commit-Position: refs/heads/master@{#413980}

Powered by Google App Engine
This is Rietveld 408576698