Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2269083003:
Add precise sysroot creator (Closed)
|
Created:
4 years, 4 months ago by Tom (Use chromium acct) Modified:
4 years, 3 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@TrustyUpdates Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd precise sysroot creator
BUG=638394
Committed: https://crrev.com/ded2d2ec84055170d34b83fd269809239c18b374
Cr-Commit-Position: refs/heads/master@{#414253}
Patch Set 1 #Patch Set 2 : Rebase #
Total comments: 2
Patch Set 3 : Update upstream branch #Patch Set 4 : Remove dependent patch set #
Dependent Patchsets: Messages
Total messages: 33 (23 generated)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thomasanderson@google.com changed reviewers: + dpranke@chromium.org
lgtm https://codereview.chromium.org/2269083003/diff/20001/build/linux/sysroot_scr... File build/linux/sysroot_scripts/sysroot-creator-precise.sh (left): https://codereview.chromium.org/2269083003/diff/20001/build/linux/sysroot_scr... build/linux/sysroot_scripts/sysroot-creator-precise.sh:21: HAS_ARCH_ARM64=1 You could probably get away with deleting HAS_ARCH_I386 and HAS_ARCH_ARM, too.
The CQ bit was checked by thomasanderson@google.com
https://codereview.chromium.org/2269083003/diff/20001/build/linux/sysroot_scr... File build/linux/sysroot_scripts/sysroot-creator-precise.sh (left): https://codereview.chromium.org/2269083003/diff/20001/build/linux/sysroot_scr... build/linux/sysroot_scripts/sysroot-creator-precise.sh:21: HAS_ARCH_ARM64=1 On 2016/08/24 18:32:49, Dirk Pranke wrote: > You could probably get away with deleting HAS_ARCH_I386 and HAS_ARCH_ARM, too. IMO we should keep those, maybe we'll need it some day. The HAS_ARCH_* variables reflect the architectures that are actually available on precise. arm64 was removed because precise doesn't support it, but trusty does.
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2270253002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Patchset #3 (id:30001) has been deleted
Patchset #3 (id:50001) has been deleted
Patchset #3 (id:70001) has been deleted
Patchset #3 (id:90001) has been deleted
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2269083003/#ps110001 (title: "Update upstream branch")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2270253002 Patch 20001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2269083003/#ps130001 (title: "Remove dependent patch set")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:130001)
Message was sent while issue was closed.
Description was changed from ========== Add precise sysroot creator BUG=638394 ========== to ========== Add precise sysroot creator BUG=638394 Committed: https://crrev.com/ded2d2ec84055170d34b83fd269809239c18b374 Cr-Commit-Position: refs/heads/master@{#414253} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/ded2d2ec84055170d34b83fd269809239c18b374 Cr-Commit-Position: refs/heads/master@{#414253} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
