Ignore swipe gestures on the NTP before the omnibox expansion starts.

Ignore swipe gestures on the NTP before the omnibox expansion starts.

BUG=631976
Committed: https://crrev.com/077a562d6d6a7b1a31a15849892eb72b0fa660c9
Cr-Commit-Position: refs/heads/master@{#414077}

[Bernhard Bauer, 2016-08-23 16:42:35]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 16:43:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-08-23 16:49:18]

bauerb@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[Bernhard Bauer, 2016-08-23 16:49:19]

Please review.

[Michael van Ouwerkerk, 2016-08-23 16:59:42]

lgtm with nit

https://codereview.chromium.org/2269993003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
(right):

https://codereview.chromium.org/2269993003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java:757: int
verticalScroll = mNewTabPageView.getVerticalScroll();
Why not use a one-liner?
return mNewTabPageView.getVerticalScroll() > 0;

https://codereview.chromium.org/2269993003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
(right):

https://codereview.chromium.org/2269993003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java:772:
int getVerticalScroll() {
While it's not exactly public, some JavaDoc seems appropriate. Something like
"@return The scroll offset in pixels".

[commit-bot: I haz the power, 2016-08-23 18:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 18:49:57]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-08-24 11:21:42]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 11:22:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-08-24 11:22:43]

As discussed offline, simplified the code to look at the translation instead.
PTAL?

[Bernhard Bauer, 2016-08-24 12:03:09]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 12:03:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 12:55:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 12:55:53]

Dry run: This issue passed the CQ dry run.

[Michael van Ouwerkerk, 2016-08-24 15:07:31]

lgtm again

[Bernhard Bauer, 2016-08-24 15:18:22]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2016-08-24 15:18:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 15:23:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-24 15:27:23]

Description was changed from

==========
Ignore swipe gestures on the NTP before the omnibox expansion starts.

BUG=631976
==========

to

==========
Ignore swipe gestures on the NTP before the omnibox expansion starts.

BUG=631976

Committed: https://crrev.com/077a562d6d6a7b1a31a15849892eb72b0fa660c9
Cr-Commit-Position: refs/heads/master@{#414077}
==========

[commit-bot: I haz the power, 2016-08-24 15:27:24]

Patchset 3 (id:??) landed as
https://crrev.com/077a562d6d6a7b1a31a15849892eb72b0fa660c9
Cr-Commit-Position: refs/heads/master@{#414077}