chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java - Issue 2269993003: Ignore swipe gestures on the NTP before the omnibox expansion starts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

Issue 2269993003: Ignore swipe gestures on the NTP before the omnibox expansion starts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sign error :) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

index 00f5b30cea3198733b0a61c361d69393a7401795..a67ab2612805febda6e7962d0695a011bf615dda 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java

@@ -1598,7 +1598,8 @@ public class ToolbarPhone extends ToolbarLayout

@Override

public boolean shouldIgnoreSwipeGesture() {

- return super.shouldIgnoreSwipeGesture() || mUrlExpansionPercent > 0f;

+ return super.shouldIgnoreSwipeGesture() || mUrlExpansionPercent > 0f

+ || mNtpSearchBoxTranslation.y < 0f;

}

private Property<TextView, Integer> buildUrlScrollProperty(

« no previous file with comments | « no previous file | no next file » | no next file with comments »