Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2276793003: Dispatch touch events to the NewTabPageView if the toolbar is moved away. (Closed)

Created:
4 years, 3 months ago by Bernhard Bauer
Modified:
4 years, 3 months ago
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue631976
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dispatch touch events to the NewTabPageView if the toolbar is moved away. As of https://crrev.com/414077, we would not recognize swipe gestures when the NTP is scrolled, but the touch event would still be dispatched by the toolbar (which would then ignore it). Instead, we now forward the touch events to the NewTabPageView if the toolbar is moved away from its original position. BUG=631976 Committed: https://crrev.com/de780ec089f9ce5a429da76635aa592f31bcab6b Cr-Commit-Position: refs/heads/master@{#414380}

Patch Set 1 #

Patch Set 2 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 3 chunks +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
Bernhard Bauer
Please review.
4 years, 3 months ago (2016-08-24 16:54:43 UTC) #5
Michael van Ouwerkerk
lgtm
4 years, 3 months ago (2016-08-24 17:12:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2276793003/20001
4 years, 3 months ago (2016-08-25 09:33:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 10:03:14 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 10:05:27 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de780ec089f9ce5a429da76635aa592f31bcab6b
Cr-Commit-Position: refs/heads/master@{#414380}

Powered by Google App Engine
This is Rietveld 408576698