chrome/test/data/webui/settings/site_details_permission_tests.js - Issue 2269963003: Site Settings Desktop: Fix bug with deleting manually added exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/settings/site_details_permission_tests.js

Issue 2269963003: Site Settings Desktop: Fix bug with deleting manually added exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/site_settings/site_details_permission.js ('K') | « chrome/browser/ui/webui/settings/site_settings_handler.cc ('k') | content/public/test/test_web_ui.h » ('j') | content/public/test/test_web_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/settings/site_details_permission_tests.js

diff --git a/chrome/test/data/webui/settings/site_details_permission_tests.js b/chrome/test/data/webui/settings/site_details_permission_tests.js

index 7864f53a47386a3505047f89b6d1be8e109da0a6..2bcecb4a41aaec9d8d60d6259532c9b6f8ba565e 100644

--- a/chrome/test/data/webui/settings/site_details_permission_tests.js

+++ b/chrome/test/data/webui/settings/site_details_permission_tests.js

@@ -59,7 +59,7 @@ cr.define('site_details_permission', function() {

return browserProxy.whenCalled('setCategoryPermissionForOrigin').then(

function(arguments) {

assertEquals(origin, arguments[0]);

- assertEquals('', arguments[1]);

+ assertEquals(origin, arguments[1]);

assertEquals(testElement.category, arguments[2]);

assertEquals(allow ?

settings.PermissionValues.ALLOW :

@@ -86,7 +86,7 @@ cr.define('site_details_permission', function() {

testElement.category = settings.ContentSettingsTypes.CAMERA;

testElement.site = {

origin: origin,

- embeddingOrigin: '',

+ embeddingOrigin: origin,

};

return browserProxy.whenCalled('getExceptionList').then(function() {

@@ -114,7 +114,7 @@ cr.define('site_details_permission', function() {