Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3233)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/settings/site_settings_handler.cc

Issue 2269963003: Site Settings Desktop: Fix bug with deleting manually added exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/resources/settings/site_settings/site_details_permission.js ('K') | « chrome/browser/resources/settings/site_settings/site_settings_behavior.js ('k') | chrome/test/data/webui/settings/site_details_permission_tests.js » ('j') | content/public/test/test_web_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/site_settings_handler.cc
diff --git a/chrome/browser/ui/webui/settings/site_settings_handler.cc b/chrome/browser/ui/webui/settings/site_settings_handler.cc
index 03595e1453cfa7e860e7f10d05e321d9194113f7..98f63d76c22adf95af675e4d1f11e56d5cb185ac 100644
--- a/chrome/browser/ui/webui/settings/site_settings_handler.cc
+++ b/chrome/browser/ui/webui/settings/site_settings_handler.cc
@@ -212,7 +212,10 @@ void SiteSettingsHandler::OnContentSettingChanged(
base::StringValue("contentSettingSitePermissionChanged"),
base::StringValue(site_settings::ContentSettingsTypeToGroupName(
content_type)),
- base::StringValue(primary_pattern.ToString()));
+ base::StringValue(primary_pattern.ToString()),
+ base::StringValue(
+ secondary_pattern == ContentSettingsPattern::Wildcard() ?
+ "" : secondary_pattern.ToString()));
}
}
« chrome/browser/resources/settings/site_settings/site_details_permission.js ('K') | « chrome/browser/resources/settings/site_settings/site_settings_behavior.js ('k') | chrome/test/data/webui/settings/site_details_permission_tests.js » ('j') | content/public/test/test_web_ui.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698