Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: content/public/test/test_web_ui.h

Issue 2269963003: Site Settings Desktop: Fix bug with deleting manually added exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/test_web_ui.h
diff --git a/content/public/test/test_web_ui.h b/content/public/test/test_web_ui.h
index 26709cf55c332ed937329d60e97a8789a0948a99..ce387714e56b9da8f418cefe6f310d1c82e232bf 100644
--- a/content/public/test/test_web_ui.h
+++ b/content/public/test/test_web_ui.h
@@ -73,17 +73,20 @@ class TestWebUI : public WebUI {
void TakeAsArg1(base::Value* arg);
void TakeAsArg2(base::Value* arg);
void TakeAsArg3(base::Value* arg);
+ void TakeAsArg4(base::Value* arg);
sky 2016/08/24 19:27:31 Seems like this should take a unique_ptr. Is there
Finnur 2016/08/25 10:29:04 Sure. Hope I got it right. :)
const std::string& function_name() const { return function_name_; }
const base::Value* arg1() const { return arg1_.get(); }
const base::Value* arg2() const { return arg2_.get(); }
const base::Value* arg3() const { return arg3_.get(); }
+ const base::Value* arg4() const { return arg4_.get(); }
private:
std::string function_name_;
std::unique_ptr<base::Value> arg1_;
std::unique_ptr<base::Value> arg2_;
std::unique_ptr<base::Value> arg3_;
+ std::unique_ptr<base::Value> arg4_;
};
const ScopedVector<CallData>& call_data() const { return call_data_; }

Powered by Google App Engine
This is Rietveld 408576698