Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2269863002: Turn on Permission Action Reporting by default. (Closed)

Created:
4 years, 4 months ago by kcarattini
Modified:
4 years, 3 months ago
Reviewers:
Nathan Parker, raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, grt+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, emilyschechter
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on Permission Action Reporting by default. BUG=613883 Committed: https://crrev.com/56bcb45af142373ddd2f7a3ee4df67ea2ee9e0dc Cr-Commit-Position: refs/heads/master@{#414627}

Patch Set 1 #

Patch Set 2 : re-disable test #

Total comments: 2

Patch Set 3 : add braces #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -32 lines) Patch
M chrome/browser/permissions/permission_uma_util.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/permissions/permission_uma_util_unittest.cc View 6 chunks +6 lines, -23 lines 0 comments Download
M chrome/browser/safe_browsing/permission_reporter_browsertest.cc View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
kcarattini
I won't submit this without the go-ahead from Emily. We can revert and merge before ...
4 years, 4 months ago (2016-08-23 04:10:23 UTC) #2
raymes
lgtm https://codereview.chromium.org/2269863002/diff/20001/chrome/browser/permissions/permission_uma_util.cc File chrome/browser/permissions/permission_uma_util.cc (right): https://codereview.chromium.org/2269863002/diff/20001/chrome/browser/permissions/permission_uma_util.cc#newcode572 chrome/browser/permissions/permission_uma_util.cc:572: switches::kDisablePermissionActionReporting)) nit: add {}
4 years, 4 months ago (2016-08-23 08:18:35 UTC) #11
kcarattini
https://codereview.chromium.org/2269863002/diff/20001/chrome/browser/permissions/permission_uma_util.cc File chrome/browser/permissions/permission_uma_util.cc (right): https://codereview.chromium.org/2269863002/diff/20001/chrome/browser/permissions/permission_uma_util.cc#newcode572 chrome/browser/permissions/permission_uma_util.cc:572: switches::kDisablePermissionActionReporting)) On 2016/08/23 08:18:35, raymes wrote: > nit: add ...
4 years, 4 months ago (2016-08-24 03:23:36 UTC) #12
Nathan Parker
lgtm
4 years, 4 months ago (2016-08-24 05:06:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269863002/60001
4 years, 3 months ago (2016-08-26 00:50:11 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-26 02:16:15 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 02:18:21 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/56bcb45af142373ddd2f7a3ee4df67ea2ee9e0dc
Cr-Commit-Position: refs/heads/master@{#414627}

Powered by Google App Engine
This is Rietveld 408576698