Turn on Permission Action Reporting by default.

chrome/browser/permissions/permission_uma_util_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_uma_util.h"
 
 #include "base/test/scoped_command_line.h"
 #include "chrome/browser/signin/fake_signin_manager_builder.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
@@ skipping 73 matching lines @@
 
  private:
   content::TestBrowserThreadBundle thread_bundle_;
   std::unique_ptr<TestingProfile> profile_;
 };
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // true if Safe Browsing is enabled, Permission Action Reporting flag is
 // enabled, not in incognito mode and signed in with default sync preferences.
 TEST_F(PermissionUmaUtilTest, IsOptedIntoPermissionActionReportingSignInCheck) {
-  base::test::ScopedCommandLine scoped_command_line;
   SetSafeBrowsing(true);
-  scoped_command_line.GetProcessCommandLine()->AppendSwitch(
-      switches::kEnablePermissionActionReporting);
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 
   FakeSignIn();
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 
   SetMockSyncService();
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(
       profile()->GetOffTheRecordProfile()));
   EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 }
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // false if Permission Action Reporting is not enabled.
 TEST_F(PermissionUmaUtilTest, IsOptedIntoPermissionActionReportingFlagCheck) {
   SetSafeBrowsing(true);
   FakeSignIn();
   SetMockSyncService();
+  EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
   {
     base::test::ScopedCommandLine scoped_command_line;
     scoped_command_line.GetProcessCommandLine()->AppendSwitch(
-        switches::kEnablePermissionActionReporting);
-    EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
+        switches::kDisablePermissionActionReporting);
+    EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
   }  // Reset the command line.
 
-  EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
+  EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 
   base::test::ScopedCommandLine scoped_command_line;
   scoped_command_line.GetProcessCommandLine()->AppendSwitch(
-      switches::kDisablePermissionActionReporting);
-  EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
+      switches::kEnablePermissionActionReporting);
+  EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 }
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // false if Safe Browsing is disabled.
 TEST_F(PermissionUmaUtilTest,
        IsOptedIntoPermissionActionReportingSafeBrowsingCheck) {
-  base::test::ScopedCommandLine scoped_command_line;
-  scoped_command_line.GetProcessCommandLine()->AppendSwitch(
-      switches::kEnablePermissionActionReporting);
   FakeSignIn();
   SetMockSyncService();
   SetSafeBrowsing(true);
   EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 
   SetSafeBrowsing(false);
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 }
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // false if Sync is disabled.
 TEST_F(PermissionUmaUtilTest,
        IsOptedIntoPermissionActionReportingProfileSyncServiceCheck) {
-  base::test::ScopedCommandLine scoped_command_line;
-  scoped_command_line.GetProcessCommandLine()->AppendSwitch(
-      switches::kEnablePermissionActionReporting);
   SetSafeBrowsing(true);
   FakeSignIn();
   ProfileSyncServiceMock* mock_sync_service = SetMockSyncService();
   EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 
   EXPECT_CALL(*mock_sync_service, CanSyncStart())
       .WillOnce(testing::Return(false));
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 }
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // false if Tab Sync and Pref Sync are not both enabled.
 TEST_F(PermissionUmaUtilTest,
        IsOptedIntoPermissionActionReportingSyncPreferenceCheck) {
-  base::test::ScopedCommandLine scoped_command_line;
-  scoped_command_line.GetProcessCommandLine()->AppendSwitch(
-      switches::kEnablePermissionActionReporting);
   SetSafeBrowsing(true);
   FakeSignIn();
   ProfileSyncServiceMock* mock_sync_service = SetMockSyncService();
   EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 
   // Reset the preferred types to return an empty set. The opted-in method will
   // return false because it needs both Tab and Pref Sync in the preferred types
   // in order to succeed.
   syncer::ModelTypeSet preferred_types;
   EXPECT_CALL(*mock_sync_service, GetPreferredDataTypes())
@@ skipping 11 matching lines @@
   preferred_types.Put(syncer::PRIORITY_PREFERENCES);
   EXPECT_CALL(*mock_sync_service, GetPreferredDataTypes())
       .WillOnce(testing::Return(preferred_types));
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 }
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // false if Sync is not active.
 TEST_F(PermissionUmaUtilTest,
        IsOptedIntoPermissionActionReportingProfileSyncServiceActiveCheck) {
-  base::test::ScopedCommandLine scoped_command_line;
-  scoped_command_line.GetProcessCommandLine()->AppendSwitch(
-      switches::kEnablePermissionActionReporting);
   SetSafeBrowsing(true);
   FakeSignIn();
   ProfileSyncServiceMock* mock_sync_service = SetMockSyncService();
   EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 
   EXPECT_CALL(*mock_sync_service, IsSyncActive())
       .WillOnce(testing::Return(false));
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 }
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // false if a custom Sync passphrase is set.
 TEST_F(PermissionUmaUtilTest,
        IsOptedIntoPermissionActionReportingSyncPassphraseCheck) {
-  base::test::ScopedCommandLine scoped_command_line;
-  scoped_command_line.GetProcessCommandLine()->AppendSwitch(
-      switches::kEnablePermissionActionReporting);
   SetSafeBrowsing(true);
   FakeSignIn();
   ProfileSyncServiceMock* mock_sync_service = SetMockSyncService();
   EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 
   EXPECT_CALL(*mock_sync_service, IsUsingSecondaryPassphrase())
       .WillOnce(testing::Return(true));
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 }