Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2124)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2269863002: Turn on Permission Action Reporting by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_uma_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 7a92ef93a1ec2968d32f475bca3934abdd16d174..1a790d5fd469eb8ae3cdf96ea953f4090e52344b 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -555,9 +555,10 @@ void PermissionUmaUtil::PermissionPromptDeniedWithPersistenceToggle(
}
bool PermissionUmaUtil::IsOptedIntoPermissionActionReporting(Profile* profile) {
- if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnablePermissionActionReporting))
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kDisablePermissionActionReporting)) {
return false;
+ }
DCHECK(profile);
if (profile->GetProfileType() == Profile::INCOGNITO_PROFILE)
@@ -568,7 +569,6 @@ bool PermissionUmaUtil::IsOptedIntoPermissionActionReporting(Profile* profile) {
ProfileSyncService* profile_sync_service =
ProfileSyncServiceFactory::GetForProfile(profile);
-
// Do not report if profile can't get a profile sync service or sync cannot
// start.
if (!(profile_sync_service && profile_sync_service->CanSyncStart()))
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_uma_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698