Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2268893004: Just use git refs for lkcr and lkgr (Closed)

Created:
4 years, 4 months ago by agable
Modified:
4 years, 4 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Just use git refs for lkcr and lkgr R=iannucci@chromium.org, martiniss@chromium.org BUG=640251 Recipe-Tryjob-Bypass-Reason: None of the affected recipes need safesync anyway, will manually roll Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/75e7fc2af1578132223591817917af6612d5525e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M recipe_modules/gclient/config.py View 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
agable
4 years, 4 months ago (2016-08-23 23:08:11 UTC) #3
martiniss
lgtm
4 years, 4 months ago (2016-08-23 23:08:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268893004/1
4 years, 4 months ago (2016-08-23 23:10:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30d27ec023f27610)
4 years, 4 months ago (2016-08-23 23:14:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268893004/1
4 years, 4 months ago (2016-08-23 23:27:04 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 23:30:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/75e7fc2af15781...

Powered by Google App Engine
This is Rietveld 408576698