Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: recipe_modules/gclient/config.py

Issue 2268893004: Just use git refs for lkcr and lkgr (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_modules/gclient/config.py
diff --git a/recipe_modules/gclient/config.py b/recipe_modules/gclient/config.py
index 851dbb0578362e7c3916e11bd1309415b2bccecb..c4566689ebc225a4e3a6dbb995f9e8f71a33bddd 100644
--- a/recipe_modules/gclient/config.py
+++ b/recipe_modules/gclient/config.py
@@ -187,24 +187,12 @@ def chromium(c):
@config_ctx(includes=['chromium'])
def chromium_lkcr(c):
- # TODO(phajdan.jr): Add git hashes for LKCR crbug.com/349277.
- if c.GIT_MODE:
- raise BadConf('Git has problems with safesync_url and LKCR, '
- 'crbug.com/349277 crbug.com/109191') # pragma: no cover
s = c.solutions[0]
- s.safesync_url = 'https://build.chromium.org/p/chromium/lkcr-status/lkgr'
- # TODO(hinoka): Once lkcr exists and is a tag, it should just be lkcr
- # rather than origin/lkcr.
s.revision = 'origin/lkcr'
@config_ctx(includes=['chromium'])
def chromium_lkgr(c):
s = c.solutions[0]
- safesync_url = 'https://chromium-status.appspot.com/lkgr'
- if c.GIT_MODE: # pragma: no cover
- safesync_url = 'https://chromium-status.appspot.com/git-lkgr'
- raise BadConf('Git has problems with safesync_url, crbug.com/109191.')
- s.safesync_url = safesync_url
s.revision = 'origin/lkgr'
@config_ctx(includes=['chromium_bare'])
@@ -689,4 +677,4 @@ def chromedriver(c):
"""Add Selenium Java tests to the gclient solution."""
c.solutions[0].custom_deps[
'src/chrome/test/chromedriver/third_party/java_tests'] = (
- ChromiumGitURL(c, 'chromium', 'deps', 'webdriver'))
+ ChromiumGitURL(c, 'chromium', 'deps', 'webdriver'))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698