Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: recipe_modules/gclient/config.py

Issue 2268893004: Just use git refs for lkcr and lkgr (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import types 5 import types
6 6
7 from recipe_engine.config import config_item_context, ConfigGroup, BadConf 7 from recipe_engine.config import config_item_context, ConfigGroup, BadConf
8 from recipe_engine.config import ConfigList, Dict, Single, Static, Set, List 8 from recipe_engine.config import ConfigList, Dict, Single, Static, Set, List
9 9
10 from . import api as gclient_api 10 from . import api as gclient_api
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 def chromium_empty(c): 180 def chromium_empty(c):
181 c.solutions[0].deps_file = '' # pragma: no cover 181 c.solutions[0].deps_file = '' # pragma: no cover
182 182
183 @config_ctx(includes=['chromium_bare']) 183 @config_ctx(includes=['chromium_bare'])
184 def chromium(c): 184 def chromium(c):
185 s = c.solutions[0] 185 s = c.solutions[0]
186 s.custom_deps = mirror_only(c, {}) 186 s.custom_deps = mirror_only(c, {})
187 187
188 @config_ctx(includes=['chromium']) 188 @config_ctx(includes=['chromium'])
189 def chromium_lkcr(c): 189 def chromium_lkcr(c):
190 # TODO(phajdan.jr): Add git hashes for LKCR crbug.com/349277.
191 if c.GIT_MODE:
192 raise BadConf('Git has problems with safesync_url and LKCR, '
193 'crbug.com/349277 crbug.com/109191') # pragma: no cover
194 s = c.solutions[0] 190 s = c.solutions[0]
195 s.safesync_url = 'https://build.chromium.org/p/chromium/lkcr-status/lkgr'
196 # TODO(hinoka): Once lkcr exists and is a tag, it should just be lkcr
197 # rather than origin/lkcr.
198 s.revision = 'origin/lkcr' 191 s.revision = 'origin/lkcr'
199 192
200 @config_ctx(includes=['chromium']) 193 @config_ctx(includes=['chromium'])
201 def chromium_lkgr(c): 194 def chromium_lkgr(c):
202 s = c.solutions[0] 195 s = c.solutions[0]
203 safesync_url = 'https://chromium-status.appspot.com/lkgr'
204 if c.GIT_MODE: # pragma: no cover
205 safesync_url = 'https://chromium-status.appspot.com/git-lkgr'
206 raise BadConf('Git has problems with safesync_url, crbug.com/109191.')
207 s.safesync_url = safesync_url
208 s.revision = 'origin/lkgr' 196 s.revision = 'origin/lkgr'
209 197
210 @config_ctx(includes=['chromium_bare']) 198 @config_ctx(includes=['chromium_bare'])
211 def android_bare(c): 199 def android_bare(c):
212 # We inherit from chromium_bare to get the got_revision mapping. 200 # We inherit from chromium_bare to get the got_revision mapping.
213 # NOTE: We don't set a specific got_revision mapping for src/repo. 201 # NOTE: We don't set a specific got_revision mapping for src/repo.
214 del c.solutions[0] 202 del c.solutions[0]
215 c.got_revision_mapping['src'] = 'got_src_revision' 203 c.got_revision_mapping['src'] = 'got_src_revision'
216 s = c.solutions.add() 204 s = c.solutions.add()
217 s.deps_file = '.DEPS.git' 205 s.deps_file = '.DEPS.git'
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
682 def valgrind(c): # pragma: no cover 670 def valgrind(c): # pragma: no cover
683 """Add Valgrind binaries to the gclient solution.""" 671 """Add Valgrind binaries to the gclient solution."""
684 c.solutions[0].custom_deps['src/third_party/valgrind'] = \ 672 c.solutions[0].custom_deps['src/third_party/valgrind'] = \
685 ChromiumGitURL(c, 'chromium', 'deps', 'valgrind', 'binaries') 673 ChromiumGitURL(c, 'chromium', 'deps', 'valgrind', 'binaries')
686 674
687 @config_ctx(includes=['chromium']) 675 @config_ctx(includes=['chromium'])
688 def chromedriver(c): 676 def chromedriver(c):
689 """Add Selenium Java tests to the gclient solution.""" 677 """Add Selenium Java tests to the gclient solution."""
690 c.solutions[0].custom_deps[ 678 c.solutions[0].custom_deps[
691 'src/chrome/test/chromedriver/third_party/java_tests'] = ( 679 'src/chrome/test/chromedriver/third_party/java_tests'] = (
692 ChromiumGitURL(c, 'chromium', 'deps', 'webdriver')) 680 ChromiumGitURL(c, 'chromium', 'deps', 'webdriver'))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698