Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2268183006: Added accessibility notification from Blink when spelling mistakes are detected. (Closed)

Created:
4 years, 4 months ago by nektarios
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni, David Tseng
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added accessibility notification from Blink when spelling mistakes are detected. I still have to figure out how to test this properly and also ask for a review from Yosin@, but please have a first look to tell me if it's in the right direction. BUG=640479 R=dmazzoni@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp View 3 chunks +13 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
nektarios
4 years, 4 months ago (2016-08-25 01:51:27 UTC) #1
nektarios
Preliminary.
4 years, 4 months ago (2016-08-25 01:52:39 UTC) #3
dmazzoni
https://codereview.chromium.org/2268183006/diff/1/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp File third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp (right): https://codereview.chromium.org/2268183006/diff/1/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp#newcode305 third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp:305: axObjectCache->handleEditableTextContentChanged(m_processingRequest->rootEditableElement()); Please add a new AXObjectCache function specifically for ...
4 years, 3 months ago (2016-08-25 15:19:04 UTC) #4
dmazzoni
4 years, 3 months ago (2016-08-25 15:20:37 UTC) #5
As for testing, could you use
LayoutTests/accessibility/contenteditable-notifications.html as a guide and
write something along those lines?

Powered by Google App Engine
This is Rietveld 408576698