Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp

Issue 2268183006: Added accessibility notification from Blink when spelling mistakes are detected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "core/editing/spellcheck/SpellCheckRequester.h" 26 #include "core/editing/spellcheck/SpellCheckRequester.h"
27 27
28 #include "core/dom/AXObjectCache.h"
28 #include "core/dom/Document.h" 29 #include "core/dom/Document.h"
29 #include "core/dom/Node.h" 30 #include "core/dom/Node.h"
30 #include "core/editing/EditingUtilities.h" 31 #include "core/editing/EditingUtilities.h"
31 #include "core/editing/markers/DocumentMarkerController.h" 32 #include "core/editing/markers/DocumentMarkerController.h"
32 #include "core/editing/spellcheck/SpellChecker.h" 33 #include "core/editing/spellcheck/SpellChecker.h"
33 #include "core/frame/LocalFrame.h" 34 #include "core/frame/LocalFrame.h"
34 #include "core/frame/Settings.h" 35 #include "core/frame/Settings.h"
35 #include "platform/text/TextCheckerClient.h" 36 #include "platform/text/TextCheckerClient.h"
36 37
37 namespace blink { 38 namespace blink {
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 { 278 {
278 TextCheckingRequestData requestData = m_processingRequest->data(); 279 TextCheckingRequestData requestData = m_processingRequest->data();
279 if (requestData.sequence() == sequence) { 280 if (requestData.sequence() == sequence) {
280 DocumentMarker::MarkerTypes markers = DocumentMarker::SpellCheckClientMa rkers(); 281 DocumentMarker::MarkerTypes markers = DocumentMarker::SpellCheckClientMa rkers();
281 if (m_processingRequest->isValid()) { 282 if (m_processingRequest->isValid()) {
282 Range* checkingRange = m_processingRequest->checkingRange(); 283 Range* checkingRange = m_processingRequest->checkingRange();
283 frame().document()->markers().removeMarkers(EphemeralRange(checkingR ange), markers); 284 frame().document()->markers().removeMarkers(EphemeralRange(checkingR ange), markers);
284 } 285 }
285 } 286 }
286 didCheck(sequence, results); 287 didCheck(sequence, results);
288 reportDocumentMarkersChangeToAccessibility();
287 } 289 }
288 290
289 void SpellCheckRequester::didCheckCancel(int sequence) 291 void SpellCheckRequester::didCheckCancel(int sequence)
290 { 292 {
291 Vector<TextCheckingResult> results; 293 Vector<TextCheckingResult> results;
292 didCheck(sequence, results); 294 didCheck(sequence, results);
293 } 295 }
294 296
297 void SpellCheckRequester::reportDocumentMarkersChangeToAccessibility() const
298 {
299 if (!m_processingRequest || !m_processingRequest->isValid())
300 return;
301
302 AXObjectCache* axObjectCache = frame().document()->existingAXObjectCache();
303 if (!axObjectCache)
304 return;
305 axObjectCache->handleEditableTextContentChanged(m_processingRequest->rootEdi tableElement());
dmazzoni 2016/08/25 15:19:04 Please add a new AXObjectCache function specifical
306 }
307
295 DEFINE_TRACE(SpellCheckRequester) 308 DEFINE_TRACE(SpellCheckRequester)
296 { 309 {
297 visitor->trace(m_frame); 310 visitor->trace(m_frame);
298 visitor->trace(m_processingRequest); 311 visitor->trace(m_processingRequest);
299 visitor->trace(m_requestQueue); 312 visitor->trace(m_requestQueue);
300 } 313 }
301 314
302 } // namespace blink 315 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698