Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1756)

Unified Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 2267713003: clang plugin: Remove check-templates toggle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/FindBadConstructsAction.cpp
diff --git a/tools/clang/plugins/FindBadConstructsAction.cpp b/tools/clang/plugins/FindBadConstructsAction.cpp
index b4920fac6de151bc939295cdd05ed8c2b7124e50..3fedd8feb088df2a5eb4f972c175e36e7c37a384 100644
--- a/tools/clang/plugins/FindBadConstructsAction.cpp
+++ b/tools/clang/plugins/FindBadConstructsAction.cpp
@@ -57,7 +57,8 @@ bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,
// and http://crbug.com/356816 are fixed.
options_.check_enum_last_value = true;
} else if (args[i] == "check-templates") {
- options_.check_templates = true;
+ // TODO(thakis): This is now always on. Remove support for this flag once
+ // the build no longer passes it in.
} else if (args[i] == "follow-macro-expansion") {
// TODO(thakis): This is now always on. Remove support for this flag once
// the build no longer passes it in.
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698