clang plugin: Remove check-templates toggle.

tools/clang/plugins/FindBadConstructsConsumer.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "FindBadConstructsConsumer.h"
 
 #include "clang/Frontend/CompilerInstance.h"
 #include "clang/AST/Attr.h"
 #include "clang/Lex/Lexer.h"
 #include "clang/Sema/Sema.h"
@@ skipping 203 matching lines @@
   CheckVarDecl(var_decl);
   return true;
 }
 
 void FindBadConstructsConsumer::CheckChromeClass(SourceLocation record_location,
                                                  CXXRecordDecl* record) {
   // By default, the clang checker doesn't check some types (templates, etc).
   // That was only a mistake; once Chromium code passes these checks, we should
   // remove the "check-templates" option and remove this code.
   // See crbug.com/441916
-  if (!options_.check_templates && IsPodOrTemplateType(*record))

[hans, 2016/08/24 23:33:19]

Wait, if options_.check_templates is always true, doesn't that mean we should
never return here, i.e. the whole if-statement (and comment above) should be
killed?

+  if (IsPodOrTemplateType(*record))
     return;
 
   bool implementation_file = InImplementationFile(record_location);
 
   if (!implementation_file) {
     // Only check for "heavy" constructors/destructors in header files;
     // within implementation files, there is no performance cost.
 
     // If this is a POD or a class template or a type dependent on a
     // templated class, assume there's no ctor/dtor/virtual method
@@ skipping 786 matching lines @@
       }
     } else if (non_reference_type->isPointerType()) {
       non_reference_type = non_reference_type->getPointeeType();
       continue;
     }
     break;
   }
 }
 
 }  // namespace chrome_checker