Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2267263002: cc: Delete all the RendererCapabilities. (Closed)

Created:
4 years, 4 months ago by danakj
Modified:
4 years, 3 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, Justin Novosad, Ken Russell (switch to Gerrit), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-prepare-mailbox-param
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Delete all the RendererCapabilities. The one left that gets used is max_texture_size, for scrollbars. Since painted scrollbars only happen on desktop, and we just make them blurry if they exceed the max size, we just hardcode a limit of 2048 which should be supported on any desktop device (it's guaranteed by DirectX9) and we're fine with scrollbars becoming less than pixel-perfect if you pinch zoom in and they become larger than max-texture-size anyhow. Everything else is unused or already deleted, so kill the structures and the thread/ipc messages related to them. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/6484c37f7b2cfcaed90cc8a37677c670a75be023 Committed: https://crrev.com/8c93919a29947fc27190cdf00bd54de1bff14d84 Cr-Original-Commit-Position: refs/heads/master@{#414212} Cr-Commit-Position: refs/heads/master@{#414553}

Patch Set 1 #

Patch Set 2 : renderer-caps: rebase-on-scrollbar-scale-at-upload #

Patch Set 3 : renderer-caps: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -310 lines) Patch
M cc/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/heads_up_display_layer.cc View 1 chunk +1 line, -6 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/output/delegating_renderer.h View 3 chunks +0 lines, -4 lines 0 comments Download
M cc/output/delegating_renderer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/output/direct_renderer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/output/gl_renderer.h View 3 chunks +0 lines, -5 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
D cc/output/renderer_capabilities.h View 1 chunk +0 lines, -28 lines 0 comments Download
D cc/output/renderer_capabilities.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D cc/output/renderer_capabilities_impl.h View 1 chunk +0 lines, -27 lines 0 comments Download
D cc/output/renderer_capabilities_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M cc/output/software_renderer.h View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/output/software_renderer.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M cc/output/vulkan_renderer.h View 2 chunks +1 line, -4 lines 0 comments Download
M cc/output/vulkan_renderer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/fake_channel_impl.h View 1 chunk +1 line, -5 lines 0 comments Download
M cc/test/fake_layer_tree_host.h View 3 chunks +0 lines, -9 lines 0 comments Download
M cc/test/fake_layer_tree_host.cc View 2 chunks +1 line, -8 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/fake_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/test/fake_proxy.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M cc/trees/channel_impl.h View 2 chunks +1 line, -6 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M cc/trees/proxy.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/trees/proxy_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/proxy_impl.cc View 2 chunks +1 line, -15 lines 0 comments Download
M cc/trees/proxy_main.h View 4 chunks +1 line, -7 lines 0 comments Download
M cc/trees/proxy_main.cc View 3 chunks +4 lines, -20 lines 0 comments Download
M cc/trees/remote_channel_impl.h View 4 chunks +2 lines, -11 lines 0 comments Download
M cc/trees/remote_channel_impl.cc View 1 5 chunks +3 lines, -16 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M cc/trees/threaded_channel.h View 1 chunk +1 line, -5 lines 0 comments Download
M cc/trees/threaded_channel.cc View 1 2 chunks +2 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 32 (20 generated)
danakj
This is waiting on reviews for removing the software param from PrepareTextureMailbox (https://codereview.chromium.org/2267993002/ and https://codereview.chromium.org/2270533002/), ...
4 years, 4 months ago (2016-08-23 17:24:14 UTC) #2
enne (OOO)
I know I suggested this approach, but I'm a little worried about 2048. The original ...
4 years, 4 months ago (2016-08-23 18:31:37 UTC) #3
danakj
OK I've rebased this on https://codereview.chromium.org/2276633003/ where we scale scrollbar bitmaps on the compositor thread ...
4 years, 4 months ago (2016-08-24 03:39:18 UTC) #4
danakj
PTAL
4 years, 4 months ago (2016-08-24 20:42:41 UTC) #10
enne (OOO)
lgtm
4 years, 4 months ago (2016-08-24 20:52:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267263002/20001
4 years, 4 months ago (2016-08-25 00:07:41 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-25 00:16:12 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6484c37f7b2cfcaed90cc8a37677c670a75be023 Cr-Commit-Position: refs/heads/master@{#414212}
4 years, 4 months ago (2016-08-25 00:17:41 UTC) #19
johnme
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2282433002/ by johnme@chromium.org. ...
4 years, 3 months ago (2016-08-25 12:36:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267263002/40001
4 years, 3 months ago (2016-08-25 22:01:15 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-25 22:09:49 UTC) #30
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 22:14:23 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8c93919a29947fc27190cdf00bd54de1bff14d84
Cr-Commit-Position: refs/heads/master@{#414553}

Powered by Google App Engine
This is Rietveld 408576698