Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2276633003:
Move scaling of ui resources for scrollbars to the time of upload (Closed)
|
Created:
4 years, 4 months ago by danakj Modified:
4 years, 3 months ago Reviewers:
enne (OOO) CC:
cc-bugs_chromium.org, chromium-reviews, piman Base URL:
https://chromium.googlesource.com/chromium/src.git@scrollbarpixeltests Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove scaling of ui resources for scrollbars to the time of upload
Instead of trying to figure out what the max texture size is on the
main thread, and scale raster to meet that, just raster freely. Then
when uploading the UIResource to a texture, we can easily tell what
the max texture size is, and if the UIResource is too large, scale it
down to fit in a texture.
R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944
Committed: https://crrev.com/cbd37e2ef2b8fa6292f5ea8cfb41df409e63cde5
Cr-Original-Commit-Position: refs/heads/master@{#414202}
Cr-Commit-Position: refs/heads/master@{#414546}
Patch Set 1 #Patch Set 2 : uploadscale: rebase #Patch Set 3 : uploadscale: rebaseline #Patch Set 4 : uploadscale: rebase-and-cctests #
Total comments: 5
Patch Set 5 : uploadscale: comments #
Total comments: 1
Patch Set 6 : uploadscale: fix #Patch Set 7 : uploadscale: rebaselineforwaterfall-plus-fuzzy #Patch Set 8 : uploadscale: fixmath #
Messages
Total messages: 60 (37 generated)
Description was changed from ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 ========== to ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
The pixel output ends up looking a lot better, which I can't really explain. I tried a lot of diff scale factors to verify that its actually doing scaling and all, and it is, it does add some aliasing, but farrrr less.
On 2016/08/24 02:04:20, danakj wrote: > The pixel output ends up looking a lot better, which I can't really explain. I > tried a lot of diff scale factors to verify that its actually doing scaling and > all, and it is, it does add some aliasing, but farrrr less. Oh I think I had incorrect baselines before from the looks of it. Ok phew.
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/24 02:06:26, danakj wrote: > On 2016/08/24 02:04:20, danakj wrote: > > The pixel output ends up looking a lot better, which I can't really explain. I > > tried a lot of diff scale factors to verify that its actually doing scaling > and > > all, and it is, it does add some aliasing, but farrrr less. > > Oh I think I had incorrect baselines before from the looks of it. Ok phew. Ok new baseline just changes very slightly. The scrollbar in this image is very tall and skinny. The width (small dimension) then changes a tiny bit. I must be doing some rounding slightly different or something, though I tried using ceil instead of floor and max_texture_size-1 instead of max_texture_size and it didn't change, so idk. Seems okay?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2276633003/diff/60001/cc/layers/scrollbar_lay... File cc/layers/scrollbar_layer_unittest.cc (right): https://codereview.chromium.org/2276633003/diff/60001/cc/layers/scrollbar_lay... cc/layers/scrollbar_layer_unittest.cc:1015: TestResourceUpload(max_texture_size / 9.9f); 9.9 O_o? https://codereview.chromium.org/2276633003/diff/60001/cc/trees/layer_tree_hos... File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2276633003/diff/60001/cc/trees/layer_tree_hos... cc/trees/layer_tree_host_impl.cc:3790: // scrollbars). Users of other types need to ensure they are not too big. This comment needs to be in the LTH header, I think? At least a warning that textures need to be smaller than max texture size? https://codereview.chromium.org/2276633003/diff/60001/cc/trees/layer_tree_hos... File cc/trees/layer_tree_host_impl.h (left): https://codereview.chromium.org/2276633003/diff/60001/cc/trees/layer_tree_hos... cc/trees/layer_tree_host_impl.h:544: gfx::Size size; Huh. I wonder why this separate parameter was added.
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
PTAL https://codereview.chromium.org/2276633003/diff/60001/cc/layers/scrollbar_lay... File cc/layers/scrollbar_layer_unittest.cc (right): https://codereview.chromium.org/2276633003/diff/60001/cc/layers/scrollbar_lay... cc/layers/scrollbar_layer_unittest.cc:1015: TestResourceUpload(max_texture_size / 9.9f); On 2016/08/24 06:03:49, enne wrote: > 9.9 O_o? Well, I was using 10, but then I wanted something not integer as a result. >_> https://codereview.chromium.org/2276633003/diff/60001/cc/trees/layer_tree_hos... File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/2276633003/diff/60001/cc/trees/layer_tree_hos... cc/trees/layer_tree_host_impl.cc:3790: // scrollbars). Users of other types need to ensure they are not too big. On 2016/08/24 06:03:50, enne wrote: > This comment needs to be in the LTH header, I think? At least a warning that > textures need to be smaller than max texture size? Done, on UIResourceClient which is where the bitmaps come from.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2276633003/diff/80001/cc/resources/ui_resourc... File cc/resources/ui_resource_client.h (right): https://codereview.chromium.org/2276633003/diff/80001/cc/resources/ui_resourc... cc/resources/ui_resource_client.h:27: // supported by the GPU. For resources that are o bigger than the viewport :o
The CQ bit was checked by danakj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org Link to the patchset: https://codereview.chromium.org/2276633003/#ps100001 (title: "uploadscale: fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by danakj@chromium.org
Description was changed from ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel NOTRY=true ==========
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
interactive_ui_tests keeps failing on trybots which appears to be https://bugs.chromium.org/p/chromium/issues/detail?id=639350. So NOTRY=true :(
Message was sent while issue was closed.
Description was changed from ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel NOTRY=true ========== to ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel NOTRY=true ========== to ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel NOTRY=true Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944 Cr-Commit-Position: refs/heads/master@{#414202} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944 Cr-Commit-Position: refs/heads/master@{#414202}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2278083002/ by johnme@chromium.org. The reason for reverting is: Sorry, seems to have caused LayerTreeHostScrollbarsPixelTest.HugeTransformScale to fail on Mac10.10 Tests, Mac10.11 Tests, Win 7 Tests x64 (1), Win10 Tests x64, Mac10.9 Tests and Linux Tests, with failures like: [8034:1287:0825/033725:3059591139598:ERROR:pixel_comparator.cc(50)] Number of pixel with an error: 672 [8034:1287:0825/033725:3059591187709:ERROR:pixel_comparator.cc(51)] Error Bounding Box : 0,304 368x66 [8034:1287:0825/033725:3059610880597:ERROR:pixel_test_utils.cc(79)] Pixels do not match! [8034:1287:0825/033725:3059610905829:ERROR:pixel_test_utils.cc(80)] Actual: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAZAAAAGQCAYAAACAvzbMAAAF4ElEQVR4nO3ZQY1CQRRFwccEUWhhgQEMYAED7FGDKtJsxsCcTYdMVQt4d3eS/w9rrTUAX+g+97nNbfeMbS5zmec8t93/2XYZgK8mIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAcnzMY/cGgOQ1r90T/rXjda67NwDwhXzCAiAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREACS43nOuzcAEJzmtPX+4b3ea+sCAJLD79t2f60lIAD8mX8gACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJAICQCIgACQCAkAiIAAkAgJAIiAAJB9NHxfMgTV5VwAAAABJRU5ErkJggg== [8034:1287:0825/033725:3059610929427:ERROR:pixel_test_utils.cc(81)] Expected: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAZAAAAGQCAYAAACAvzbMAAAF4klEQVR4nO3ZQY1CQRRFwfcJotDCYhQgAAsIQABqMEXSo2HOpkOmysC7u5N0H2utNQBf6DGPuc9994xtfuZnXvPadv+07TIAX01AAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIDk/Jzn7g0AyXveuyf8a+fb3HZvAOALecICIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQABIBASAREAASAQEgERAAEgEBIBEQAJLzda67NwAQXOay9f7xWZ+1dQEAyWlOc8yx7f6x1hIQAP7MHwgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICACJgACQCAgAiYAAkAgIAImAAJAICADJLzUdF8xyVTjQAAAAAElFTkSuQmCC ../../cc/test/layer_tree_pixel_test.cc:124: Failure Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_) Actual: false Expected: true.
Message was sent while issue was closed.
Description was changed from ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel NOTRY=true Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944 Cr-Commit-Position: refs/heads/master@{#414202} ========== to ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel NOTRY=true Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944 Cr-Commit-Position: refs/heads/master@{#414202} ==========
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
So.. on the trybots the inner antialiased edge is (148,255,148) which is the halfwhite halfgreen color. The outer edge is (94,255,94). On the waterfall the inner edge is (149,255,149) and the outer edge is (94,255,94).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by danakj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org Link to the patchset: https://codereview.chromium.org/2276633003/#ps120001 (title: "uploadscale: rebaselineforwaterfall-plus-fuzzy")
I've used the waterfall version as the expected png now, and added fuzziness to allow what the trybots get (and what I get locally).
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by danakj@chromium.org
Description was changed from ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel NOTRY=true Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944 Cr-Commit-Position: refs/heads/master@{#414202} ========== to ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944 Cr-Commit-Position: refs/heads/master@{#414202} ==========
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I've updated the math to use ceiledsize(size * (max_texture_size-1)/width) instead of flooredsize(size * max_texture_size/width), so that we don't end up with a 0 width or height as pointed out by clusterfuzz.
The CQ bit was unchecked by danakj@chromium.org
On 2016/08/25 19:47:28, danakj wrote: > I've updated the math to use ceiledsize(size * (max_texture_size-1)/width) > instead of flooredsize(size * max_texture_size/width), so that we don't end up > with a 0 width or height as pointed out by clusterfuzz. Of course, I have now no idea if this will pass or fail on the waterfall again. :\
The CQ bit was checked by danakj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org Link to the patchset: https://codereview.chromium.org/2276633003/#ps140001 (title: "uploadscale: fixmath")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944 Cr-Commit-Position: refs/heads/master@{#414202} ========== to ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944 Cr-Commit-Position: refs/heads/master@{#414202} ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944 Cr-Commit-Position: refs/heads/master@{#414202} ========== to ========== Move scaling of ui resources for scrollbars to the time of upload Instead of trying to figure out what the max texture size is on the main thread, and scale raster to meet that, just raster freely. Then when uploading the UIResource to a texture, we can easily tell what the max texture size is, and if the UIResource is too large, scale it down to fit in a texture. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/941e52edd1522f7c3935aa4f4d763c43578b4944 Committed: https://crrev.com/cbd37e2ef2b8fa6292f5ea8cfb41df409e63cde5 Cr-Original-Commit-Position: refs/heads/master@{#414202} Cr-Commit-Position: refs/heads/master@{#414546} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/cbd37e2ef2b8fa6292f5ea8cfb41df409e63cde5 Cr-Commit-Position: refs/heads/master@{#414546} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
