fpdfsdk/formfiller/cffl_formfiller.h - Issue 2266943002: Destroy window before cleaning up combobox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/formfiller/cffl_formfiller.h

Issue 2266943002: Destroy window before cleaning up combobox (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Destroy window before cleaning up combobox Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/formfiller/cffl_formfiller.h

diff --git a/fpdfsdk/formfiller/cffl_formfiller.h b/fpdfsdk/formfiller/cffl_formfiller.h

index b1e323185b5d9f6ac88ddd8d94a652fcfcef29b3..9d4127d2d311cec283b6a62a39d2a7ec741fca81 100644

--- a/fpdfsdk/formfiller/cffl_formfiller.h

+++ b/fpdfsdk/formfiller/cffl_formfiller.h

@@ -154,6 +154,8 @@ class CFFL_FormFiller : public IPWL_Provider, public CPWL_TimerHandler {

protected:

using CFFL_PageView2PDFWindow = std::map<CPDFSDK_PageView*, CPWL_Wnd*>;

+ void DestroyWindows();

CPDFDoc_Environment* m_pApp;

CPDFSDK_Widget* m_pWidget;

CPDFSDK_Annot* m_pAnnot;