Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2266943002: Destroy window before cleaning up combobox (Closed)

Created:
4 years, 4 months ago by dsinclair
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Destroy window before cleaning up combobox Currently, when we destroy a CFFL_ComboBox we'll cleanup the fontmap and then call the destructor for the parent type. This will case the PWL_Wnd to be destroyed. In this case, the window is a PWL_Edit. On destruction it will reset the focus which causes the text selection to change, which asks the font map for data but we've already destroyed the font map. This CL forces the destruction of the window earlier in order to have the fontmap available. A followup bug is filed to correct the location of the fontmap so we don't have this dependency. BUG=chromium:637546 Committed: https://pdfium.googlesource.com/pdfium/+/28a4a2410f24910c709578d981cae3bb8153fdba

Patch Set 1 #

Patch Set 2 : Destroy window before cleaning up combobox #

Total comments: 2

Patch Set 3 : Update textfield #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M fpdfsdk/formfiller/cffl_combobox.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
dsinclair
PTAL
4 years, 4 months ago (2016-08-22 14:57:47 UTC) #6
Wei Li
https://codereview.chromium.org/2266943002/diff/20001/fpdfsdk/formfiller/cffl_combobox.cpp File fpdfsdk/formfiller/cffl_combobox.cpp (right): https://codereview.chromium.org/2266943002/diff/20001/fpdfsdk/formfiller/cffl_combobox.cpp#newcode33 fpdfsdk/formfiller/cffl_combobox.cpp:33: // until the PWL_Edit is done with it. pdfium:566 ...
4 years, 4 months ago (2016-08-22 19:26:56 UTC) #7
dsinclair
https://codereview.chromium.org/2266943002/diff/20001/fpdfsdk/formfiller/cffl_combobox.cpp File fpdfsdk/formfiller/cffl_combobox.cpp (right): https://codereview.chromium.org/2266943002/diff/20001/fpdfsdk/formfiller/cffl_combobox.cpp#newcode33 fpdfsdk/formfiller/cffl_combobox.cpp:33: // until the PWL_Edit is done with it. pdfium:566 ...
4 years, 4 months ago (2016-08-22 19:32:08 UTC) #8
Wei Li
On 2016/08/22 19:32:08, dsinclair wrote: > https://codereview.chromium.org/2266943002/diff/20001/fpdfsdk/formfiller/cffl_combobox.cpp > File fpdfsdk/formfiller/cffl_combobox.cpp (right): > > https://codereview.chromium.org/2266943002/diff/20001/fpdfsdk/formfiller/cffl_combobox.cpp#newcode33 > ...
4 years, 4 months ago (2016-08-22 19:44:21 UTC) #9
dsinclair
PTAL.
4 years, 4 months ago (2016-08-22 19:58:28 UTC) #15
Wei Li
lgtm
4 years, 4 months ago (2016-08-22 20:34:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266943002/60001
4 years, 4 months ago (2016-08-22 20:35:48 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 20:36:08 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/28a4a2410f24910c709578d981cae3bb8153...

Powered by Google App Engine
This is Rietveld 408576698