fpdfsdk/formfiller/cffl_formfiller.cpp - Issue 2266943002: Destroy window before cleaning up combobox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/formfiller/cffl_formfiller.cpp

Issue 2266943002: Destroy window before cleaning up combobox (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Destroy window before cleaning up combobox Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/formfiller/cffl_formfiller.cpp

diff --git a/fpdfsdk/formfiller/cffl_formfiller.cpp b/fpdfsdk/formfiller/cffl_formfiller.cpp

index f2c34647d077b9fa6caa5bdcb064f9ad57df20d2..92e9282a74923321250a8cdf2b7da406e45b5d1d 100644

--- a/fpdfsdk/formfiller/cffl_formfiller.cpp

+++ b/fpdfsdk/formfiller/cffl_formfiller.cpp

@@ -27,6 +27,10 @@ CFFL_FormFiller::CFFL_FormFiller(CPDFDoc_Environment* pApp,

}

CFFL_FormFiller::~CFFL_FormFiller() {

+ DestroyWindows();

+void CFFL_FormFiller::DestroyWindows() {

for (const auto& it : m_Maps) {

CPWL_Wnd* pWnd = it.second;

CFFL_PrivateData* pData = (CFFL_PrivateData*)pWnd->GetAttachedData();